Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Device (Matter Switch) Shin Dong A ES productId: 0x1000 #1872

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

New Device (Matter Switch) Shin Dong A ES productId: 0x1000 #1872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1dcd629
Adding fingerprint for device
lelandblue Jan 14, 2025
4b2a3c7
Adding override for end point 2
lelandblue Jan 14, 2025
857c2f4
Adding quotes around ID
lelandblue Jan 14, 2025
2e18057
Fixing the profile
lelandblue Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions drivers/SmartThings/matter-switch/fingerprints.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,12 @@ matterManufacturer:
vendorId: 0x137F
productId: 0x027B
deviceProfileName: plug-binary
#Shin Dong-A ES
- id: "5483/4096"
deviceLabel: Smart Wall Switch
vendorId: 0x156B
productId: 0x1000
deviceProfileName: switch-binary
#SONOFF
- id: "SONOFF MINIR4M"
deviceLabel: Smart Plug-in Unit
Expand Down
1 change: 1 addition & 0 deletions drivers/SmartThings/matter-switch/src/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ local device_type_attribute_map = {
local child_device_profile_overrides = {
{ vendor_id = 0x1321, product_id = 0x000C, child_profile = "switch-binary" },
{ vendor_id = 0x1321, product_id = 0x000D, child_profile = "switch-binary" },
{ vendor_id = 0x156B, product_id = 0x1000, child_profile = "switch-binary" }, -- Shin Dong-A ES Smart Switch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might override the profile for every child device, including endpoints 3-6 which should use a color temperature light profile

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you are right, for some reason I thought this was only for overriding switch vs plug, but you're right this would apply to all the child devices.

We could make it so it just applies to the switch/plug types though as I think that is the only situation where this would be used. Does that make sense?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense! Should that be in a separate PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we can put it in a separate PR in case it needs to be used by another device before this one completes cert (unlikely, but might as well)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok that sounds good, I'll put something together!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on the deployment of that change too, we may need to update this PR to be rebased so that the partner can also get that experience as well

We are asking them to test with this driver sharing link, so it would b best to have that in there too

Thanks @ctowns and @nickolas-deboom

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a PR to address this here: #1874

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1874 has been merged

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I should post this here, but [email protected] says that support requests are no longer be monitored.
I checked out what you discussed and I think the profile we initially set up makes more sense.
The reason for this is that the switch directly controls the lights and plugs through relays inside the switch, not the IoT lights and plugs.
So Endpoints 1 and 2 are better labeled as plugs.
Also, Endpoints 3 through 6 can be viewed as lights.
This is because the switch directly controls the dimming and color temperature of the lights.
Please review again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case it sounds like we can remove this device from the child_device_profile_overrides list and change the fingerprint to "plug-binary" instead of "switch-binary". That way the first endpoint will join as a plug and the remaining end points will have child devices created based on their device type. cc @lelandblue @ctowns

}

local detect_matter_thing
Expand Down
Loading