-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EdgeDriver for POPP Smart Thermostat (Zigbee) added/reworked #285
EdgeDriver for POPP Smart Thermostat (Zigbee) added/reworked #285
Conversation
Unit Test Results 1 files ±0 307 suites +1 0s ⏱️ ±0s For more details on these errors, see this check. Results for commit ffedc76. ± Comparison against base commit 4a5c100. ♻️ This comment has been updated with latest results. |
Channel deleted. |
Could you please tell me why all zigbee-thermostat tests have failed and why? I can't currently track this in my editor. I use the latest CLI (smartthings.exe) and lua_libs_api_v1_44X. Thank you in advance. |
…mke/SmartThingsEdgeDrivers into add/popp-smart-thermostat
Duplicate profile check: Passed - no duplicate profiles detected. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 89af95b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not rename existing profiles as already-installed devices are using them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope it's all fixed with ee6848d now
…artThingsEdgeDrivers/pull/285/files/aca52e4fce7ecbffb6493215eef4d15308c707a7 revert changes from review https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/285/files/aca52e4fce7ecbffb6493215eef4d15308c707a7 avoid breaking existing popp/danfoss edge drivers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unsuccessful tests comment is out of date simply because it was run before the test CI changed. I verified locally that all tests pass. This looks good to go.
I've tried to add mockup tests for the custom capabilities and manufacturer-specific cluster attributes but with no success. I would be glad to get some more guidance here if this matters for the WWST to succeed.
Thank you in advance.