Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdgeDriver for POPP Smart Thermostat (Zigbee) added/reworked #285

Merged

Conversation

ronie-z-wave
Copy link
Contributor

I've tried to add mockup tests for the custom capabilities and manufacturer-specific cluster attributes but with no success. I would be glad to get some more guidance here if this matters for the WWST to succeed.

Thank you in advance.

@github-actions
Copy link

github-actions bot commented Sep 30, 2022

Unit Test Results

       1 files  ±0     307 suites  +1   0s ⏱️ ±0s
1 379 tests  - 5  1 378 ✔️  - 6  0 💤 ±0  0 ±0  1 🔥 +1 
2 444 runs  +2  2 442 ✔️ ±0  0 💤 ±0  0 ±0  2 🔥 +2 

For more details on these errors, see this check.

Results for commit ffedc76. ± Comparison against base commit 4a5c100.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 30, 2022

Channel deleted.

@ronie-z-wave
Copy link
Contributor Author

Could you please tell me why all zigbee-thermostat tests have failed and why? I can't currently track this in my editor. I use the latest CLI (smartthings.exe) and lua_libs_api_v1_44X. Thank you in advance.

ronie-z-wave and others added 21 commits October 27, 2022 09:49
@github-actions
Copy link

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link

github-actions bot commented Jun 29, 2023

Test Results

     54 files     346 suites   0s ⏱️
1 618 tests 1 528 ✔️ 0 💤 0    90 🔥
2 844 runs  2 715 ✔️ 0 💤 0  129 🔥

For more details on these errors, see this check.

Results for commit 89af95b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 29, 2023

File Coverage
All files NaN%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 89af95b

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not rename existing profiles as already-installed devices are using them

Copy link
Contributor

@zwave-mke zwave-mke Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it's all fixed with ee6848d now

Copy link
Contributor

@greens greens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unsuccessful tests comment is out of date simply because it was run before the test CI changed. I verified locally that all tests pass. This looks good to go.

@lelandblue lelandblue merged commit 4a09f4a into SmartThingsCommunity:main Oct 30, 2023
8 of 11 checks passed
@ronie-z-wave ronie-z-wave deleted the add/popp-smart-thermostat branch November 9, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants