Fix esp32 multicore lockup #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could revert #2696 so that multicore devices have both cores available by default... though I'm inclined to leave it alone for now. |
mikee47
force-pushed
the
fix/esp32-multicore-lockup
branch
from
361f856 to
20e1588
Compare
Required for IPC support.
With Basic_WiFi sample, system crashes in multicore. If station is initialised *before* access point, this doesn't happen. Deferring the call to `esp_wifi_start` fixes the issue.
mikee47
force-pushed
the
fix/esp32-multicore-lockup
branch
from
20e1588 to
8e93a18
Compare
|
@mikee47 ready with this PR? |
|
Yes, thanks. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken IPC calling interrupts on esp32 chips. Closes #2653.
Cause is due to an incorrect linker flag which resulted in critical high-level interrupt handling code from the ESP IDF not getting linked.
Testing also revealed a race condition during access point initialisation. The
Basic_Wifisample first initialises the access point, then the station. Shortly after startup, some internal structure for the access point gets invalidated and causes an access violation. It appears to be related to callingesp_wifi_starttwice.