drm/atomic: Better logging for atomic requests #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drakulix
force-pushed
the
drm/better_logs
branch
from
234293c to
3616765
Compare
Drakulix
force-pushed
the
drm/better_logs
branch
from
3616765 to
1ede934
Compare
cmeissl
requested changes
Jan 13, 2025
Co-authored-by: Christian Meissl <[email protected]>
Drakulix
force-pushed
the
drm/better_logs
branch
from
6da1b06 to
5ed3394
Compare
cmeissl
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid screen configurationissues are rare these days, but decrypting them from logs is very cumbersome whenever they occur. This is mostly due to the property handles not having any meaning, if you don't have the property mapping.So we do log the mapping now as well.
Additionally in debug mode we construct the whole request differently to give us actually nice output. We need a bunch of collections to do so, so this is inefficient enough to only do in debug builds, long term it might be better to find a solution how to deconstruct drm-rs's
AtomicModeReq. But for now this should be a significant improvement.