address comments

Snapchat · Jul 24, 2024 · bf60220 · bf60220
1 parent 1a4080d
commit bf60220
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/support-lib/cpp/SharedFuture.hpp b/support-lib/cpp/SharedFuture.hpp
@@ -63,13 +63,6 @@ class SharedFuture {
         co_return transform(cpy);
     }
 
-    // Overload for T = void or `transform` takes no arugment.
-    template<typename Func, typename = std::enable_if_t<!std::is_invocable_v<Func, const SharedFuture<T>&>>>
-    SharedFuture<std::remove_cv_t<std::remove_reference_t<std::invoke_result_t<Func>>>> then(Func transform) const {
-        co_await SharedFuture(*this); // retain copy during coroutine suspension
-        co_return transform();
-    }
-
     // -- coroutine support implementation only; not intended externally --
 
     bool await_ready() const {
@@ -132,8 +125,8 @@ SharedFuture<T>::SharedFuture(Future<T>&& future) {
                 } else {
                     sharedStates->storedValue = futureResult.get();
                 }
-            } catch (const std::exception& e) {
-                sharedStates->storedValue = make_unexpected(std::make_exception_ptr(e));
+            } catch (...) {
+                sharedStates->storedValue = make_unexpected(std::current_exception());
             }
             return std::move(sharedStates->coroutineHandles);
         }();

diff --git a/test-suite/handwritten-src/objc/tests/DBSharedFutureTest.mm b/test-suite/handwritten-src/objc/tests/DBSharedFutureTest.mm
@@ -55,10 +55,10 @@ - (void)testThen
 
     XCTAssertEqual(futureInt.get(), 42);
 
-    auto voidFuture = transformedString.then([]() {});
+    auto voidFuture = transformedString.then([](auto) {});
     voidFuture.wait();
 
-    auto intFuture2 = voidFuture.then([]() { return 43; });
+    auto intFuture2 = voidFuture.then([](auto) { return 43; });
     XCTAssertEqual(intFuture2.get(), 43);
 }
 
@@ -72,7 +72,7 @@ - (void)testException
 
     XCTAssertThrows(futureInt.get());
 
-    auto thenResult = futureInt.then([]() { return 43; });
+    auto thenResult = futureInt.then([](const auto& resolved) { return resolved.get(); });
     XCTAssertThrows(thenResult.get());
 
     auto withExceptionHandling = futureInt.then([](const auto& resolved) {