Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TS compilation error on tsc 4.5.4 #153

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix TS compilation error on tsc 4.5.4 #153

merged 1 commit into from
Nov 22, 2023

Conversation

mutagene
Copy link
Contributor

Fixes for error when running bazel run //test-suite:server-ts -

../../djinni/vendor/third-party/proto/ts/test.ts:3:23 - error TS2497: This module can only be referenced with ECMAScript imports/exports by turning on the 'esModuleInterop' flag and referencing its default export.

3 import * as Long from "long";
                        ~~~~~~

../../djinni/vendor/third-party/proto/ts/test2.ts:3:23 - error TS2497: This module can only be referenced with ECMAScript imports/exports by turning on the 'esModuleInterop' flag and referencing its default export.

3 import * as Long from "long";

@li-feng-sc
Copy link
Contributor

Thank you! I'll run some tests with Snap's codebase and get back to you!

@li-feng-sc li-feng-sc merged commit 6aa86dc into Snapchat:main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-feng-sc li-feng-sc li-feng-sc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mutagene @li-feng-sc