Fix exception propagation to JS for async void functions #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI error is not from your PR. Should be fixed with #162 if you pull that from |
…result from future so the exception can be thrown, catched and translated
arekmula
force-pushed
the
fix/exceptions-propagation-from-async-void-functions
branch
from
4a34a19 to
4061704
Compare
|
I rebased on top of the current main branch |
li-feng-sc
approved these changes
Feb 20, 2024
arekmula
deleted the
fix/exceptions-propagation-from-async-void-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
We encountered an issue where exceptions were not properly propagated for functions returning
future<void>. It's because future was never resolved in thedoResolvefor void types and exception was never raised there so it could be caught and translated usingdjinni_native_exception_to_js