Make DJFuture results nonnull in objective C #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-feng-sc
approved these changes
Jun 26, 2024
li-feng-sc
approved these changes
Jun 26, 2024
|
@jb-gcx I had to revert this change in the version snap uses because nonnull get/set prevents future<optional<>> |
|
That's too bad, I thought I tested that case. I guess my test was not representative, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #169
Of the test failures I mentioned in the issue, all now cause a compiler warning except for
testFutureRoundtripWithNSNull. Unfortunately I can't find a way to prevent the parameterlesssetValuefrom being called for non-void promises.