Move result out of Future instead of copying it #177
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that results are copied out of djinni::Futures instead of moved, probably due to a forgotten std::move.
Example:
auto ptr = djinni::Promise<std::unique_ptr<int>>::resolve(nullptr).get();
.Before this it didn't work (called copy constructor of unique_ptr), now it does.
Testing
I wanted to add a test to verify this works and doesn't break with future versions, but there are no dedicated C++ tests yet. I don't have experience with bazel, so I just added an XCTest to do this. I hope that's okay with you.