Fix published provideClass return type inference. #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the type assertion, compiler resulting npm package type definition for
provideClass
looks like:The last bit (
ConstructorReturnType<InjectableClass<Services, Service, Tokens>>>>
) is somehow problematic. Resolving types for services provided using the function breaks, e.g.container.providesClass('serivice', Service)
returns a container of typeContainer<{ service: any }>
.The fix addresses the issue by asserting the function's return type, so the generated function signature looks like:
With that
container.providesClass('serivice', Service)
correctly returns a container of typeContainer<{ service: Service }>
.