Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ClassInjectable infer dependency types. Update docs with an example that compiles. #9

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Make ClassInjectable infer dependency types. Update docs with an example that compiles. #9

merged 2 commits into from
Oct 22, 2024

Conversation

kburov-sc
Copy link
Collaborator

Addresses #8, examples from the docs now compile, also makes ClassInjectable usable directly as it now infers class's dependencies.

mikalai-snap
mikalai-snap approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@mikalai-snap mikalai-snap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The second example peace of code didn't compile (it has to use providesValue instead of provides), so I decided to update it by myself:) I also changed naming to be more real life as opposed to be abstract.

@kburov-sc kburov-sc merged commit 60a89bf into main Oct 22, 2024
1 check passed
@kburov-sc kburov-sc deleted the kb-class-injectable-docs branch October 22, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikalai-snap mikalai-snap mikalai-snap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kburov-sc @mikalai-snap