Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]:Fixes height and width of notes card #38

Conversation

ShaikArshidBanu
Copy link
Contributor

fixes issue #21 by additionally implementing changes mentioned in #22

solution obtained:
Screenshot 2024-01-02 141057

@iaayushmaan
Copy link

@ShaikArshidBanu I don't think this aligns with the description that @nisha-laur gave. You have to use a grid layout, rather than mere flex-box.

@nisha-laur
Copy link
Contributor

yeah @ShaikArshidBanu your code is just expanding the width of the notes div which is not looking nice . You are supposed to make a grid layout in which the height of the div changes in accordance with the width in relation the length of the text in it . Please look into that .

@ShaikArshidBanu
Copy link
Contributor Author

yeah @ShaikArshidBanu your code is just expanding the width of the notes div which is not looking nice . You are supposed to make a grid layout in which the height of the div changes in accordance with the width in relation the length of the text in it . Please look into that .

Okay I'll look into it

@ShaikArshidBanu
Copy link
Contributor Author

@nisha-laur in order to achieve the layout as described in #22 we have to fix the height of index.html page not all the notes can be saved in that format in case of large number of notes and as an alternative solution we should provide an additional button to view all the saved notes so that we can navigate to new page which contains list of all the notes and we can view each notes by clicking that notesconatiner in which we can further add fetures like sorting according to time or alphabetical order of title.
I would like to work on this if you assign it to me.

@nisha-laur
Copy link
Contributor

@ShaikArshidBanu Okay you can try that .

@ShaikArshidBanu
Copy link
Contributor Author

@ShaikArshidBanu Okay you can try that .

@nisha-laur Okay I'll work on this

@nisha-laur nisha-laur closed this Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants