-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Snowbridge teleports #1069
Conversation
// Teleport required fees. | ||
ReceiveTeleportedAsset(total.into()), | ||
// Pay for execution. | ||
BuyExecution { fees: xcm_fee, weight_limit: Unlimited }, | ||
// Fund the snowbridge sovereign with the required deposit for creation. | ||
DepositAsset { assets: Definite(deposit.into()), beneficiary: bridge_location }, | ||
// Switch origin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Switch origin. | |
// Only our inbound-queue pallet is allowed to invoke `UniversalOrigin` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed.
polkadot-sdk
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is pointing to a stale polkadot-sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I have double checked this. main
is stale. Probably because we are half way through a merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
814b2d0
to
76180b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1069 +/- ##
=======================================
Coverage 80.55% 80.55%
=======================================
Files 55 55
Lines 2273 2273
Branches 71 71
=======================================
Hits 1831 1831
Misses 425 425
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Adddresses PR feedback paritytech/polkadot-sdk#2522 (comment)
Re-order xcm so we do not need a custom teleporter.
Polkadot-sdk: Snowfork/polkadot-sdk#77