Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Snowbridge teleports #1069

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Conversation

alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Dec 19, 2023

Adddresses PR feedback paritytech/polkadot-sdk#2522 (comment)

Re-order xcm so we do not need a custom teleporter.

Polkadot-sdk: Snowfork/polkadot-sdk#77

// Teleport required fees.
ReceiveTeleportedAsset(total.into()),
// Pay for execution.
BuyExecution { fees: xcm_fee, weight_limit: Unlimited },
// Fund the snowbridge sovereign with the required deposit for creation.
DepositAsset { assets: Definite(deposit.into()), beneficiary: bridge_location },
// Switch origin.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Switch origin.
// Only our inbound-queue pallet is allowed to invoke `UniversalOrigin`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

polkadot-sdk Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is pointing to a stale polkadot-sdk

Copy link
Contributor Author

@alistair-singh alistair-singh Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I have double checked this. main is stale. Probably because we are half way through a merge.

Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@alistair-singh alistair-singh force-pushed the alistair/remove-snowbridge-teleports branch from 814b2d0 to 76180b0 Compare December 19, 2023 09:49
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0becdae) 80.55% compared to head (814b2d0) 80.55%.
Report is 1 commits behind head on main.

❗ Current head 814b2d0 differs from pull request most recent head 76180b0. Consider uploading reports for the commit 76180b0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   80.55%   80.55%           
=======================================
  Files          55       55           
  Lines        2273     2273           
  Branches       71       71           
=======================================
  Hits         1831     1831           
  Misses        425      425           
  Partials       17       17           
Flag Coverage Δ
rust 80.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alistair-singh alistair-singh merged commit 5aca479 into main Dec 19, 2023
7 checks passed
@alistair-singh alistair-singh deleted the alistair/remove-snowbridge-teleports branch December 19, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants