-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Milagro-BLS and Eth-ABI from crates.io #1124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a companion PR Snowfork/polkadot-sdk#105 to update Cargo.lock or the CI task zepter run check
will fail.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1124 +/- ##
==========================================
- Coverage 76.04% 75.95% -0.10%
==========================================
Files 58 58
Lines 2455 2458 +3
Branches 72 72
==========================================
Hits 1867 1867
- Misses 571 574 +3
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Nice catch! |
The diff looks a bit weird (includes my minimal spec changes in #1119), perhaps a rebase on |
Thanks, seems to be resolved after my latest commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @vgeddes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
No description provided.