Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Milagro-BLS and Eth-ABI from crates.io #1124

Merged
merged 11 commits into from
Jan 24, 2024
Merged

Use Milagro-BLS and Eth-ABI from crates.io #1124

merged 11 commits into from
Jan 24, 2024

Conversation

vgeddes
Copy link
Collaborator

@vgeddes vgeddes commented Jan 22, 2024

No description provided.

Copy link
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a companion PR Snowfork/polkadot-sdk#105 to update Cargo.lock or the CI task zepter run check will fail.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (53a5522) 76.04% compared to head (b6f8b5b) 75.95%.

Files Patch % Lines
parachain/primitives/beacon/src/types.rs 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1124      +/-   ##
==========================================
- Coverage   76.04%   75.95%   -0.10%     
==========================================
  Files          58       58              
  Lines        2455     2458       +3     
  Branches       72       72              
==========================================
  Hits         1867     1867              
- Misses        571      574       +3     
  Partials       17       17              
Flag Coverage Δ
rust 75.04% <33.33%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yrong yrong mentioned this pull request Jan 23, 2024
@vgeddes
Copy link
Collaborator Author

vgeddes commented Jan 23, 2024

Add a companion PR Snowfork/polkadot-sdk#105 to update Cargo.lock or the CI task zepter run check will fail.

Nice catch!

@claravanstaden
Copy link
Contributor

The diff looks a bit weird (includes my minimal spec changes in #1119), perhaps a rebase on main will fix it?

@vgeddes
Copy link
Collaborator Author

vgeddes commented Jan 23, 2024

The diff looks a bit weird (includes my minimal spec changes in #1119), perhaps a rebase on main will fix it?

Thanks, seems to be resolved after my latest commits.

Copy link
Contributor

@claravanstaden claravanstaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @vgeddes!

Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@vgeddes vgeddes merged commit ef3d640 into main Jan 24, 2024
7 checks passed
@vgeddes vgeddes deleted the milagro branch January 24, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants