Fix for signature malleability #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relayer/relays/beefy/parameters.go
Outdated
| @@ -89,13 +93,37 @@ func toBeefyClientCommitment(c *types.Commitment) *contracts.BeefyClientCommitme | |||
| } | |||
| } | |||
|
|
|||
| func cleanSignature(input types.BeefySignature) (uint8, [32]byte, [32]byte) { | |||
| func cleanSignature(input types.BeefySignature) (v uint8, r [32]byte, s [32]byte, err error) { | |||
There was a problem hiding this comment.
Out of interest, why name the return parameters?
There was a problem hiding this comment.
Nothing special, just for return with error easily.
snowbridge/relayer/relays/beefy/parameters.go
Line 106 in aa41d7d
alistair-singh
approved these changes
Nov 26, 2024
| @@ -22,9 +22,9 @@ var rootCmd = &cobra.Command{ | |||
| func init() { | |||
| rootCmd.AddCommand(run.Command()) | |||
| rootCmd.AddCommand(getBlockCmd()) | |||
| //rootCmd.AddCommand(fetchMessagesCmd()) | |||
Co-authored-by: Alistair Singh <[email protected]>
Co-authored-by: Alistair Singh <[email protected]>
vgeddes
reviewed
Nov 27, 2024
| } | ||
| reverted = true | ||
| } | ||
| return v, r, s, reverted, nil |
There was a problem hiding this comment.
The reverted variable doesn't seem to be used anywhere?
There was a problem hiding this comment.
snowbridge/relayer/cmd/scan_beefy.go
Lines 183 to 186 in ce46a00
Just used to inspect the beefy signatures.
vgeddes
approved these changes
Nov 29, 2024
…nowfork/snowbridge into ron/fix-signature-malleability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://linear.app/snowfork/issue/SNO-1215