Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Native ETH in v1 #1354

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Support Native ETH in v1 #1354

wants to merge 2 commits into from

Conversation

alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Dec 12, 2024

Changes

  1. Use the 0x0000000000000000000000000000000000000000 token address as Native ETH.
  2. When sendToken is called with the 0x00.. an amount of msg.value is locked in asset hub agent.
  3. To avoid clashing with fees/rewards and locked funds, fees/rewards are collected and dispensed from the Gateway Proxy account.
  4. The existing funds in the agents will be migrated on upgrade.
  5. Scripts which mentions FundAgent are now called FundGateway

Related polkadot-sdk: paritytech/polkadot-sdk#6855

TODO

  • Fix tests
  • Add tests for the Eth asserting msg.value.
  • Migrate agent funds to gateway proxy on upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant