Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive layers - respect layer height range modifiers. #5941

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

vovodroid
Copy link
Contributor

This PR enforces Height Range Modifiers for Adaptive Layers. If object has such modifiers they layer height will be used and not be affected by Adaptive/Smooth/Editing:

image

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay.
I've reviewed the changes and tested them; they work like a charm 👍
I noticed you temporarily turned off optimization (see my other comment).
Could you take a look at that? Otherwise, everything looks good to me.

src/slic3r/GUI/GLCanvas3D.cpp Outdated Show resolved Hide resolved
@vovodroid
Copy link
Contributor Author

I'm thinking about using zero value for not forcing layer height and using adaptive height.

@SoftFever SoftFever merged commit b3b0961 into SoftFever:main Nov 21, 2024
16 checks passed
@SoftFever
Copy link
Owner

I'm thinking about using zero value for not forcing layer height and using adaptive height.

I actually like the current behavior(with your changes), use zero value will make the logic less intuitive IMO.

@vovodroid vovodroid deleted the adaptive-respect-range-pr branch November 21, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants