capitalize support names in the UI for consistency #8089
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noisyfox
requested changes
Jan 20, 2025
| def->enum_labels.push_back(L("Normal (auto)")); | ||
| def->enum_labels.push_back(L("Tree (auto)")); | ||
| def->enum_labels.push_back(L("Normal (manual)")); | ||
| def->enum_labels.push_back(L("Tree (manual)")); |
There was a problem hiding this comment.
Don't update values, update labels only, otherwise all existing profiles/projects will break.
There was a problem hiding this comment.
Thanks for the feedback, I'll revise this.
ShaneDelmore
force-pushed
the
capitalize_support_names
branch
from
410f3d5 to
c3de1a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just capitalized Tree and Normal plus added a space before (auto) for UI consistency.
Screenshots/Recordings/Graphs
Tests
I manually verified slicing still works and selects the correct support type