Feat/add distributed tracing support #32
Conversation
Release v1.3.0
Release v1.4.0
…n methods based on ARCH
…ntext propagation feature
pkg/solace/message/message.go
Outdated
| // GetCreationTraceContext will return the trace context metadata used for distributed message tracing message | ||
| // creation context information across service boundaries. | ||
| // It allows correlating the producer with the consumers of a message, regardless of intermediary | ||
| // instrumentation. It must not be altered by intermediaries. | ||
| // If the content is not accessible, an empty slice will be returned and the ok flag will be false. | ||
| GetCreationTraceContext() (traceID [16]byte, spanID [8]byte, sampled bool, traceState string, ok bool) | ||
|
|
||
| // SetTraceContext will set creation trace context metadata used for distributed message tracing. | ||
| // Creation context considered to be immutable, and should not be set multiple times. | ||
| // If the content could not be set into the message, the ok flag will be false. | ||
| SetCreationTraceContext(traceID [16]byte, spanID [8]byte, sampled bool, traceState string) (ok bool) | ||
|
|
||
| // GetTransportTraceContext will return the trace context metadata used for distributed message tracing | ||
| // It allows correlating the producer and the consumer with an intermediary. | ||
| // It also allows correlating multiple intermediaries among each other. | ||
| // When no transport context is present it may return a creation context when available as | ||
| // an initial transport context. | ||
| // If the content is not accessible, an empty slice will be returned and the ok flag will be false. | ||
| GetTransportTraceContext() (traceID [16]byte, spanID [8]byte, sampled bool, traceState string, ok bool) | ||
|
|
||
| // SetTraceContext will set transport trace context metadata used for distributed message tracing. | ||
| // If the content could not be set into the message, the ok flag will be false. | ||
| SetTransportTraceContext(traceID [16]byte, spanID [8]byte, sampled bool, traceState string) (ok bool) | ||
|
|
||
| // GetBaggage will return the baggage string associated with the message | ||
| // If the content is not accessible, an empty slice will | ||
| // be returned and the ok flag will be false. | ||
| GetBaggage() (baggage string, ok bool) | ||
|
|
||
| // SetBaggage will set the baggage string associated with the message | ||
| SetBaggage(baggage string) error | ||
|
|
There was a problem hiding this comment.
I don't think we wanted to expose the interfaces to the world in the Message interface. I think we decided to keep the functions public but hidden to deter users from using these directly. @mgevantmakher can confirm.
There was a problem hiding this comment.
okay, I will make the update to remove these
pkg/solace/message/message.go
Outdated
| // It allows correlating the producer with the consumers of a message, regardless of intermediary | ||
| // instrumentation. It must not be altered by intermediaries. | ||
| // If the content is not accessible, an empty slice will be returned and the ok flag will be false. | ||
| GetCreationTraceContext() (traceID [16]byte, spanID [8]byte, sampled bool, traceState string, ok bool) |
There was a problem hiding this comment.
all otel methods need to be removed from a public interface
|
@oodigie looks like there is a failing test from the last push https://github.com/SolaceDev/pubsubplus-go-client/actions/runs/6490386492/job/17626071508?pr=32 which appears to be a newly added test. |
|
The failing test has been updated |
…rom the ccsmp message
There was a problem hiding this comment.
So far the source looks good to me but I want to compare the tests in solace otel integration project. To ensure nothing is missing.
There is a conflict with dev so that should be resolved as well.
The last jenkins run seems to be having timing issues in the integration tests on linux arm64 along with a test failure on intel linux.
The intel test failure was for test:
Based on the time stamps in the linux arm64 test the initial failure was caused by a known issue in the solace broker where tls truststore updates cause service instabliity in the broker. With the follow tests (based on timestamps) execute immediately afterwards and even smf client connections got interrupted. The broker instability might affect more then just semp services now in the broker. After enough time connections can be established and test start passing again.
Will continue after I have a better understand the otel field behvaiour from the otel intergration project in pr https://github.com/SolaceDev/pubsubplus-opentelemetry-go-integration/pull/3.
|
Okay, thanks @cjwmorgan-sol . I have merged changes from dev into this branch and resolved the conflicts. We can investigate the failing integration tests further but I do not think they are related to the changes in this PR. They are mostly related to OAuth/SSL - http://jenkins2/job/solacedev.pubsubplus-go-client/job/feat%252Fadd-distributed-tracing-support/25/#showFailuresLink |
Signed-off-by: Chris Morgan <[email protected]>
….com/SolaceDev/pubsubplus-go-client into feat/add-distributed-tracing-support
Changes: