Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOL-112353: Start and termination of a RequestReplyMessagePublisher integration tests #42

Merged
merged 9 commits into from
Mar 15, 2024

Conversation

oodigie
Copy link

@oodigie oodigie commented Mar 1, 2024

Changes:

  • added some of the publisher termination integration tests
  • added more test cases to cover publisher termination
  • refactor: renamed the requestReplyPublisher variable in the integration tests to publisher

Copy link

@cjwmorgan-sol cjwmorgan-sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some use of time.Sleep that should be addressed if possible. Or better rational to under stand it.
There are some questions as well. Likely means the test need better comments.
Git actions all pass and jenkins has no request reply failures.

test/request_reply_message_publisher_test.go Outdated Show resolved Hide resolved
test/request_reply_message_publisher_test.go Outdated Show resolved Hide resolved
test/request_reply_message_publisher_test.go Outdated Show resolved Hide resolved
test/request_reply_message_publisher_test.go Outdated Show resolved Hide resolved
test/request_reply_message_publisher_test.go Outdated Show resolved Hide resolved
@oodigie oodigie requested a review from cjwmorgan-sol March 8, 2024 13:53
Copy link

@cjwmorgan-sol cjwmorgan-sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
gitactions and jenkins show no publisher failures.
This ready for merge.

@cjwmorgan-sol cjwmorgan-sol merged commit fe3b170 into SOL-62455 Mar 15, 2024
4 checks passed
@cjwmorgan-sol cjwmorgan-sol deleted the SOL-111699--SOL-112353 branch March 15, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants