-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOL-112353: Start and termination of a RequestReplyMessagePublisher integration tests #42
Conversation
…on tests to publisher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some use of time.Sleep that should be addressed if possible. Or better rational to under stand it.
There are some questions as well. Likely means the test need better comments.
Git actions all pass and jenkins has no request reply failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
gitactions and jenkins show no publisher failures.
This ready for merge.
Changes: