-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOL-112355: Integration tests to cover the processing of requests and responses #44
Conversation
…cessing using the RequestReplyMessagePublisher and RequestReplyMessageReceiver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a failing test due to a receiver configuration issue.
@oodigie please address it.
With PR #43 merged this PR might need to sync with the base feature branch SOL-62455 now. |
… size to handle the publish size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and git actions passed.
But jenkins show request reply failure so there must some issue in here.
@oodigie please take look.
Since these test pass on relatively clean nodes I suspect this is timing related on busy nodes.
@cjwmorgan-sol, Seeing as the average time to typically receive a reply per message is about < 1 second, probably < 100 milliseconds (changes per version of the broker), I will either have to increase the timeout to allow receiving all the replies or reduce the amount of messages being published. I will reduce the total published message to 500. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All check passing in git actions, and the only jenkins failure were independent of these changes (all known intermittent).
This looks good to me.
And is ready for merge.
Changes: