Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOL-126461: Updated Go API to CCSMP version 7.31.0. #65

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Conversation

TrentDaniel
Copy link

No description provided.

Copy link

gitstream-cm bot commented Oct 4, 2024

Please mark whether you used Copilot to assist coding in this PR

  • Copilot Assisted

@TrentDaniel TrentDaniel requested a review from oodigie October 7, 2024 16:51
oodigie
oodigie previously approved these changes Oct 7, 2024
Copy link

@oodigie oodigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binaries and the header files have been updated. LGTM!

@oodigie oodigie self-requested a review October 8, 2024 18:45
@oodigie oodigie dismissed their stale review October 8, 2024 18:45

There are weird errors in Jenkins

@oodigie
Copy link

oodigie commented Oct 8, 2024

We are seeing weird errors in the Jenkins Go pipeline. Further investigation is required.

@oodigie
Copy link

oodigie commented Oct 9, 2024

@TrentDaniel, there is an error on the Jenkins Go pipeline with your last changes

@sdewilde sdewilde self-requested a review October 22, 2024 17:15
@sdewilde
Copy link

@TrentDaniel @cjwmorgan-sol We got a conflict here with the alpine changes, not sure if making that change will remove the review but happy to re-review after that change if needed

@TrentDaniel
Copy link
Author

@TrentDaniel @cjwmorgan-sol We got a conflict here with the alpine changes, not sure if making that change will remove the review but happy to re-review after that change if needed

Just pushed changes after resolving the conflict. We'll see how automation goes.

@TrentDaniel TrentDaniel merged commit 2f864c6 into dev Oct 23, 2024
6 checks passed
@TrentDaniel TrentDaniel deleted the SOL-126461 branch October 23, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants