forked from SolaceProducts/pubsubplus-go-client
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOL-59692: Provide Ability to NACK a Specific AD Message and Force Re-delivery #66
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
90c3175
EBP-52: Implement the receiver builder configuration for message sett…
oodigie 37f8578
EBP-54: Implement the Settle() method
oodigie 648b60f
EBP-54: fixed doc string format on MessageSettlementOutcome
oodigie fe4303c
EBP-58: added new metrics and response code for Nack
oodigie 578d614
EBP-58: tracked auto-acks and substract it from settledAccepted
oodigie 4eb83a4
EBP-60: write unit and integration tests
oodigie 94fdbfa
Adding some dummy tests to see through a small change.
b9b192b
A few more simple tests.
2e5f086
EBP-79: Go NACK integration tests
5410a87
EBP-79: Go NACK integration tests
9ca4d04
Left a test focused by accident, sorry.
5b211de
merged changes from dev into branch and resolved merge conflicts
oodigie af60446
EBP-61: Write unit tests for the NACK feature
oodigie 633ed96
EBP-79: a few more tests.
49e8fad
fixed the failing unit test
oodigie 71864ce
EBP-79: Finishing touches for integration tests
605ce3f
EBP-79: returning error on Build() if garbage was mixed in to setter.
8ee4129
Merge pull request #70 from SolaceDev/SOL-59692
gszol c6894e6
SOL-59692: updated some integration test cases
oodigie c5a7de9
Merge branch 'SOL-59692' into EBP-79_NACK_tests
gszol 9af2289
Merge pull request #69 from SolaceDev/EBP-79_NACK_tests
oodigie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which indentation is our coding standard, before or after?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go has its own standard for formatting for running
go fmt
on the project.Not sure indentation is included in that for all cases.
If go fmt is happy will this the indentation standard for solace by default is 4 spaces. Unless there is overriding factor like
go fmt
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gszol, I just run the usual
go fmt
on the code before/while committing the code changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If everyone's happy, I'm happy :-)