EBP-24: As a developer, I can retrieve the cache request ID from a cached message #78
Conversation
|
Please mark whether you used Copilot to assist coding in this PR
|
…mpleted the cache messages feature
| cacheID, errInfo := ccsmp.SolClientMessageGetCacheRequestID(inboundMessage.messagePointer) | ||
| if errInfo != nil { | ||
| if errInfo.ReturnCode == ccsmp.SolClientReturnCodeFail { | ||
| logging.Default.Debug(fmt.Sprintf("Encountered error retrieving Cache ID: %s, subcode: %d", errInfo.GetMessageAsString(), errInfo.SubCode)) |
There was a problem hiding this comment.
@oodigie , based on the API and Application Log Levels confluence page, this log seems to be informing the application that
An unexpected event or occurrence that does not affect the sane operation of the SDK or application.
so I would expect this to be a notice log. This would be coerced into an info log in the case of the Go API since AFAIK we do not have notice logs. I think that the application would want to be notified at a higher level of logging than debug if their operation failed. Please either make this change or let me know if you have a different opinion.
There was a problem hiding this comment.
@TrentDaniel, I took a look at that confluence page and I think you are right. I will update this now.
…ieving cache request ID from a message
oodigie
dismissed
TrentDaniel’s stale review
I have made the suggested change for the log level from Debug to Info and responded to the other comment.
Changes: