EBP-474: Test for large cached messages #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please mark whether you used Copilot to assist coding in this PR
|
oodigie
reviewed
Feb 6, 2025
| } | ||
| Expect(messagingService.Metrics().GetValue(metrics.CacheRequestsSent)).To(BeNumerically("==", 1)) | ||
| Expect(messagingService.Metrics().GetValue(metrics.CacheRequestsSucceeded)).To(BeNumerically("==", 6)) | ||
| Expect(messagingService.Metrics().GetValue(metrics.CacheRequestsFailed)).To(BeNumerically("==", 0)) |
There was a problem hiding this comment.
Please can you explain why there would be exactly 6 cache requests that succeeded? I don't see anywhere we send 6 cache requests.
oodigie
reviewed
Feb 6, 2025
| ValidCachedMessageAge int32 = 5 | ||
| ValidMaxCachedMessages int32 = 10 | ||
| ValidCachedMessageAge int32 = 0 | ||
| ValidMaxCachedMessages int32 = 0 |
There was a problem hiding this comment.
@TrentDaniel, I am just curious to know why these were set to zero?
sdewilde
reviewed
Feb 6, 2025
| err = receiver.AddSubscription(resource.TopicSubscriptionOf(publishTopic)) | ||
| Expect(err).To(BeNil()) | ||
| /* NOTE: Intiialize the cache with very large messages. This will be overwritten by the next test, | ||
| * so we don't need to worry about long messages causing other tests to take longer. |
There was a problem hiding this comment.
What happens if you chose to run just a few random sections (like when splitting up CI vs RC tests). Should we be doing some cleanup?
| for i := 0; i < numExpectedCacheMessages; i++ { | ||
| Eventually(receivedMsgChan, "5s").Should(Receive(&msg)) | ||
| Expect(msg).ToNot(BeNil()) | ||
| /* NOTE: Can't assert topic from received message because of wildcard in cache request. */ |
There was a problem hiding this comment.
We still have the publishTopic, can we use that? Or at least confirm some part of the topic matches?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache request that require multiple messages (Get Next) in reply.