-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATAGO-88877: (Chore) Enable Whitesource Scan on Merge to Main #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Changes:** 1. **Dependency Updates:** - Updated the `solace_ai_connector` dependency in `pyproject.toml` from `>=0.0.1` to `>=0.1.3` to incorporate the latest features and fixes. 2. **Enhancements to `slack_input.py`:** - Added the `input_type` field to `user_properties` to specify the source as Slack. - Improved message acknowledgment logic to ensure the acknowledgment message is only sent for direct messages (channel type is `im`). - Enhanced the `process_text_for_mentions` method to improve performance by skipping unnecessary processing when no mentions exist in the text. 3. **Enhancements to `slack_output.py`:** - Introduced `streaming_state` management to track and handle message streaming states and ensure accurate Slack message updates. - Added mechanisms to handle the first and last chunks of streamed content, ensuring the state is updated correctly. - Incorporated logic to manage the lifetime of streaming states, automatically aging out old states to maintain performance. - Provided better handling for message indexing and bulk updates to ensure efficient Slack message posting without redundancy. - Added error handling to clean up acknowledgment messages after message streaming is complete. **Overall Impact:** These enhancements improve the reliability and efficiency of the Slack input and output components within the Solace AI Connector, ensuring smoother operation and better handling of streamed messages, acknowledgments, and user mentions.
* chore: Add prettytable dependency for Slack message formatting * Merge branch 'main' into better_slack_formatting * Better spacing around the table
* Passing slacks ts and thread_ts as is, and useing reply_to_thread and thread_id for cm logic * Passing slacks ts and thread_ts as is, and useing reply_to_thread and thread_id for cm logic * minor update
* Fixed syntax error * Fix personal reply
…plete status when the response complete event arrives (#8)
AI-178: Align streaming field naming conventions in the Slack connector with those used in cognitive-mesh
DATAGO-87497 Update CI workflow with new python version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short PR to enable whitesource scan.