DATAGO-89836: Support Scan for Public CEMA #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudraneel-chakraborty
had a problem deploying
to
build_pr
GitHub Actions
Failure
rudraneel-chakraborty
had a problem deploying
to
build_pr
GitHub Actions
Failure
rudraneel-chakraborty
temporarily deployed
to
build_pr
GitHub Actions
Inactive
rudraneel-chakraborty
temporarily deployed
to
build_pr
GitHub Actions
Inactive
| @@ -45,6 +48,7 @@ public void runScan(String messagingServiceId, String filePathAndName) throws In | |||
| .messagingServiceId(messagingServiceId) | |||
| .scanId(idGenerator.generateRandomUniqueId()) | |||
| .destinations(List.of("FILE_WRITER")) | |||
| .orgId(eventPortalProperties.getOrganizationId()) | |||
There was a problem hiding this comment.
for command line scan, pass in the org_id from application.yaml
| ScanStatus status) { | ||
|
|
||
| Validate.notBlank(orgId, "Organization ID cannot be null or empty"); |
There was a problem hiding this comment.
I see that this error message have been used in many places. Can we add a CONSTANT for it plz?
moodiRealist
approved these changes
Jan 30, 2025
rudraneel-chakraborty
temporarily deployed
to
build_pr
GitHub Actions
Inactive
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Implement the asks of https://sol-jira.atlassian.net/browse/DATAGO-89836
There is an ep-core component to this ticket : https://github.com/SolaceDev/maas-ep-core/pull/3392
How was this change implemented?
Java
How was this change tested?
IT, Manually in local/cloud environment
Is there anything the reviewers should focus on/be aware of?
We mostly have Unit tests written for the scan functionality and not many IT tests. Due to the complexity introduced because of camel I am guessing. As a result, tne unit tests are scattered all over the place and the reafactoring required to have a cohesive IT test setup for scan is beyond the scope.
As a result, I tried to add tests but the coverage and test setup MUST be improved