SOL-117452: Fix extra P2P topic subscription on request reply publisher #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…faces SOL-111817: added request_reply_message_publisher.go module with interfaces SOL-111816: Updated messaging service interface and added RequestReplyMessagingService Signed-off-by: Chris Morgan <[email protected]>
…aitTime duration which is not used Signed-off-by: Chris Morgan <[email protected]>
…er using direct publisher as a base Signed-off-by: Chris Morgan <[email protected]>
SOL-111859: Added requestor correlation id generation using correlation prefix '#GOS' SOL-111858: added Requestor interface for replyTo subscription management in core publisher SOL-111859: Added correlation id management function and correlationEntry struct SOL-111859: changed terminate graceful termination to block on outstanding correlation replies SOL-112067: added SetCorrelationID and SetReplyToDestination function to use on outboundMessageImpl struct Signed-off-by: Chris Morgan <[email protected]>
…ty provider configuration and struct pointer reference Signed-off-by: Chris Morgan <[email protected]>
…ith base implementation of receiver wrapping a direct receiver instance SOL-112140: Changed core.Receiver to have core.Replier accessor for internal replier operations SOL-112141: updated OutboundMessageImpl set all reply message fields SOL-112142: Added RequestReplyMessageReceiverBuilderImpl with configuration methods, updated request reply service to return new builder, builder wraps direct message receiver builder SOL-112143: Created replierImpl that extracts inbound message correlation id and reply to destination before callback to be independent of inbound message for reply message Signed-off-by: Chris Morgan <[email protected]>
SOL-112144: Added mock core replier for unit tests compilation SOL-111860: fixed core publisher error format issue found in unit testing Signed-off-by: Chris Morgan <[email protected]>
SOL-112144: fix go fmt for receiver unit tests Signed-off-by: Chris Morgan <[email protected]>
SOL-111860: fixed publisher single select staement by unblocking on correlation complete channel signal Signed-off-by: Chris Morgan <[email protected]>
Signed-off-by: Chris Morgan <[email protected]>
…ation type access for compilation on darwin platforms Signed-off-by: Chris Morgan <[email protected]>
…message Also added type check error path for Reply method as well Signed-off-by: Chris Morgan <[email protected]>
…replyto subscription that are not reply messages Signed-off-by: Chris Morgan <[email protected]>
…n correlation terminate channel Signed-off-by: Chris Morgan <[email protected]>
Sol 62455 poc: initial implementation review
… with builder tests only to start Signed-off-by: Chris Morgan <[email protected]>
… RequestReplyMessagePublisherBuilder and RequestReplyMessageReceiverBuilder
SOL-112352: RequestReplyMessageBuilders instantiation and configuration integration tests
…on tests to publisher
…tests Fixed issue with publish replyHandler parameter Signed-off-by: Chris Morgan <[email protected]>
SOL-111860: fixed reply error outcome response for failure to publish, this is no longer return illegal state error instead of core error Signed-off-by: Chris Morgan <[email protected]>
…t module Added initial replier unit tests Signed-off-by: Chris Morgan <[email protected]>
SOL-112354: Start and termination of a RequestReplyMessageReceiver integration tests
… size to handle the publish size
SOL-112355: Integration tests to cover the processing of requests and responses
Signed-off-by: Chris Morgan <[email protected]>
…utcomes Signed-off-by: Chris Morgan <[email protected]>
Signed-off-by: Chris Morgan <[email protected]>
SOL-112353: Start and termination of a RequestReplyMessagePublisher integration tests
…CORRELATION_ID_PREFIX Signed-off-by: Chris Morgan <[email protected]>
…ck would forward messages to go publisher regardless of prefix Signed-off-by: Chris Morgan <[email protected]>
…erflow on Reply SOL-116504: added unit test for PublisherOverflowError on Replier.Reply SOL-116504: reworked core Replier interface for internal errorInfo type and updated ReplierImpl to handle errorInfo and error type mapping from core replier Signed-off-by: Chris Morgan <[email protected]>
SOL-116516: fix for the bounce read/write access for traceID and spanID
dispatchMap and go declared C structure (solClient_session_rxMsgDispatchFuncInfo_t) with a pointer within appear to cause stack copying/memory moving problems with CGO. dispatchMap is totally unnecessary, so remove it. Move stack allocation of C datastructure to inside the C code, so we pass only primitives and uintptr between Go and C.
Correct indentation for go format checker.
Chenage a parameter name from dispatchId to dispatchID to satisfy staticcheck ... unknown reasoning.
Bug SOL-114567 fix for subscription dispatch info runtime stack issues. Should avoid any go runtime stack issues around native solclient dispatch info struct allocation on the go stack.
Address new native subscription model to avoid c dispatch info struct in go for replyto topics Signed-off-by: Chris Morgan <[email protected]>
Signed-off-by: Chris Morgan <[email protected]>
…ondition in CCSMP
SOL-62455: Feature add request reply messaging
…extra reply to topic subscription for publisher Signed-off-by: Chris Morgan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.