Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.0.0 #273

Merged
merged 12 commits into from
Apr 3, 2024
Merged

Release 4.0.0 #273

merged 12 commits into from
Apr 3, 2024

Conversation

Nephery
Copy link
Collaborator

@Nephery Nephery commented Mar 15, 2024

No description provided.

@mayur-solace
DATAGO-67282: NACK Support for Consumer bindings (#270)
332275c 
* DATAGO-67282: Added NACK Support feature, removed ITs related to rebind
* DATAGO-67282: Removed stale tests related to rebind
* DATAGO-67282: Added IT, Removed Commented Code
* DATAGO-67282: Added javadocs
* DATAGO-67282: Updated the version in pom. Updated the spring-cloud-dependencies version and sol-jcsmp version
* DATAGO-67282: Remove unused consumer binding properties flowPreRebindWaitTimeout, flowRebindBackOffInitialInterval, flowRebindBackOffMaxInterval, flowRebindBackOffMultiplier
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 15, 2024 •
edited
Loading

Test Results

739 tests   - 101   737 ✅  - 101   11m 45s ⏱️ - 4m 30s
 34 suites  -   4     2 💤 ±  0 
 34 files    -   4     0 ❌ ±  0 

Results for commit aa55c54. ± Comparison against base commit 3094b7a.

This pull request removes 158 and adds 57 tests. Note that renamed tests count towards both. 
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testAnonConsumerDiscard{Class, boolean, JCSMPSession, SempV2Api, TestInfo}[1]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testAnonConsumerDiscard{Class, boolean, JCSMPSession, SempV2Api, TestInfo}[2]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testAnonConsumerDiscard{Class, boolean, JCSMPSession, SempV2Api, TestInfo}[3]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testAnonConsumerDiscard{Class, boolean, JCSMPSession, SempV2Api, TestInfo}[4]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testAnonConsumerErrorQueueRepublish{Class, boolean, JCSMPSession, SempV2Api, TestInfo}[1]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testAnonConsumerErrorQueueRepublish{Class, boolean, JCSMPSession, SempV2Api, TestInfo}[2]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testAnonConsumerErrorQueueRepublish{Class, boolean, JCSMPSession, SempV2Api, TestInfo}[3]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testAnonConsumerErrorQueueRepublish{Class, boolean, JCSMPSession, SempV2Api, TestInfo}[4]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testConsumerErrorQueueRepublish{Class, boolean, JCSMPSession, SempV2Api, TestInfo}[1]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testConsumerErrorQueueRepublish{Class, boolean, JCSMPSession, SempV2Api, TestInfo}[2]
…

com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testConsumerErrorQueueRepublish{Class, boolean, boolean, JCSMPSession, SempV2Api, TestInfo}[1]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testConsumerErrorQueueRepublish{Class, boolean, boolean, JCSMPSession, SempV2Api, TestInfo}[2]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testConsumerErrorQueueRepublish{Class, boolean, boolean, JCSMPSession, SempV2Api, TestInfo}[3]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testConsumerErrorQueueRepublish{Class, boolean, boolean, JCSMPSession, SempV2Api, TestInfo}[4]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testConsumerErrorQueueRepublish{Class, boolean, boolean, JCSMPSession, SempV2Api, TestInfo}[5]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testConsumerErrorQueueRepublish{Class, boolean, boolean, JCSMPSession, SempV2Api, TestInfo}[6]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testConsumerErrorQueueRepublish{Class, boolean, boolean, JCSMPSession, SempV2Api, TestInfo}[7]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testConsumerErrorQueueRepublish{Class, boolean, boolean, JCSMPSession, SempV2Api, TestInfo}[8]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testConsumerRequeue{Class, boolean, boolean, SoftAssertions, TestInfo}[1]
com.solace.spring.cloud.stream.binder.SolaceBinderBasicIT ‑ testConsumerRequeue{Class, boolean, boolean, SoftAssertions, TestInfo}[2]
…

♻️ This comment has been updated with latest results.

@Nephery Nephery marked this pull request as ready for review March 15, 2024 19:59
@Nephery Nephery requested a review from amanek-solace March 15, 2024 19:59
mayur-solace and others added 7 commits March 25, 2024 12:44
@mayur-solace
Merge remote-tracking branch 'upstream/master' into stage-4.0.0
5964f7e 
# Conflicts:
#	pom.xml
#	solace-spring-cloud-bom/README.md
#	solace-spring-cloud-bom/pom.xml
#	solace-spring-cloud-parent/pom.xml
#	solace-spring-cloud-starters/solace-spring-cloud-stream-starter/README.adoc
#	solace-spring-cloud-starters/solace-spring-cloud-stream-starter/pom.xml
#	solace-spring-cloud-stream-binder/solace-spring-cloud-stream-binder-core/pom.xml
#	solace-spring-cloud-stream-binder/solace-spring-cloud-stream-binder-core/src/main/java/com/solace/spring/cloud/stream/binder/properties/SolaceConsumerProperties.java
#	solace-spring-cloud-stream-binder/solace-spring-cloud-stream-binder-core/src/test/java/com/solace/spring/cloud/stream/binder/properties/SolaceConsumerPropertiesTest.java
#	solace-spring-cloud-stream-binder/solace-spring-cloud-stream-binder/pom.xml
#	solace-spring-cloud-stream-binder/solace-spring-cloud-stream-binder/src/test/java/com/solace/spring/cloud/stream/binder/SolaceBinderBasicIT.java
@mayur-solace
DATAGO-67282: Resolve merge conflicts
cef0a7f
@mayur-solace @Nephery
DATAGO-67282 Resolve Merge Conflicts with master (#281)
114ab2e 
* Release 3.2.0 (#279) (#280)

* DATAGO-67277: Feature to exclude header on consumer binding

Co-authored-by: mayur-solace <[email protected]>

* DATAGO-67282: Resolve merge conflicts

---------

Co-authored-by: Jeffrey D <[email protected]>
@Nephery
Revert "DATAGO-67282 Resolve Merge Conflicts with master (#281)" (#282)
90120f6 
This reverts commit 114ab2e.
@Nephery
Merge pull request #283 from mayur-solace/DATAGO-67282_Merging
ed8f8d1 
DATAGO-67282 Resolve Merge Conflicts with master
@Nephery
Merge branch 'master' into stage-4.0.0
aa55c54
@mayur-solace
DATAGO-67282: Update the Spring Boot and Spring Cloud Version (#287)
b29c7f9
@Nephery Nephery merged commit d7095b9 into master Apr 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanek-solace amanek-solace amanek-solace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nephery @amanek-solace @mayur-solace