Allow empty string for encrypted data #476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 20, 2020 19:55
Decrypting empty string will simply return an empty string without failing
|
Thanks for the PR! The tests are failing because we still don't have good support for PRs :( see #67). I'm fine with merging and letting the tests running on master for now. One question I do have - how do we define a valid input. Calling a decrypt function without anything to decrypt sounds more like a bad request to me :) Maybe the fix should be in the init container? Not to send empty string at all? Unless I'm not understanding the usecase... |
|
Closed for being stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decrypting empty string will simply return an empty string without failing. This is to support one of our use case where I have an app that I want to instantiate many times and some variant of this app don't require all secrets. Since I want to reuse the same template for the config map, I would simply put an empty string for the secrets that are not required instead of having to encrypt a dummy value for the decryptor to not fail.