Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unitarias #69

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Unitarias #69

wants to merge 36 commits into from

Conversation

Kiro8888
Copy link

Blog beta with datatable and permissions

kiro added 30 commits August 12, 2023 16:16
absence: change the file datatable and integrate in blog
llamar el authot bien, filtrados y llamar la vista de actualizar
cambiar la funcion de actualizar, la ruta.
el buscar
Falta:
1.Limpiar codigo
2.Revisar bug
Copy link
Contributor

@allexiusw allexiusw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment to consider factory-boy for fixtures.

@@ -9,7 +9,12 @@
class TestEntryDetail(TestCase):

def setUp(self):
self.entry_1 = models.Entry.objects.create(title=u'Welcome!', is_published=True)
self.entry_1 = models.Entry.objects.create(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For fixtures in test you can use factory-boy it will allow you to easy create fixtures and deal with django model dependencies. https://factoryboy.readthedocs.io/en/stable/

self.entry = models.Entry.objects.create(title=u'Welcome!',
content='### Some Content',
is_published=False)
self.entry = models.Entry.objects.create(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use factory-boy here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants