Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKS chart #458

Closed
wants to merge 87 commits into from
Closed

SKS chart #458

wants to merge 87 commits into from

Conversation

mikolaj-jalocha
Copy link
Member

@mikolaj-jalocha mikolaj-jalocha commented Nov 30, 2024

Massive glowup

  • line char has been added that shows forecasted and already measured data
  • on tooltip we have 2 values along with hour of measurement
  • there are some todos, I think they are not that crucial and it'd be good to close main issue and then perform some final touches.
  • the PR also solves this task (chore(sks-menu)/change color of arrows #501)

#378

@mikolaj-jalocha mikolaj-jalocha marked this pull request as ready for review November 30, 2024 20:55
@simon-the-shark
Copy link
Member

Hey! Didn't look more into this, but I have some quick thoughts/suggestions about the design:

  1. vertical scale labels maybe should be on the left side - like in parking chart to be consistent??
  2. I think we need at least 4h scope of time for it to be useful
  3. We can have few times more bars - just the labels don't need to be for every one of them. I think when we have more dense bars, this should look better. Maybe more like in the Google Maps? I thinks it's pretty neatly done there.
  4. maybe some small and vague horizontal lines?? - quite optional
  5. maybe smaller corner radius of the bars??????????
  6. maybe let's put the whole chart into some greyish container? - to be more consistent with the parkings?

not about the chart: maybe we should also show current people counter and trend in the bottom drawer too? cause the app bar one is kinda in the background. In the parkings we have the current number too, so it would be more consistent.

Tell me what you think! Hopefully I don't interfere with your vision too much 🦔

@tomasz-trela
Copy link
Member

I think vertical bars should be at right site. Similar to parkings. I think interval should be bigger.

@tomasz-trela
Copy link
Member

Hey! Didn't look more into this, but I have some quick thoughts/suggestions about the design:

  1. vertical scale labels maybe should be on the left side - like in parking chart to be consistent??
  2. I think we need at least 4h scope of time for it to be useful
  3. We can have few times more bars - just the labels don't need to be for every one of them. I think when we have more dense bars, this should look better. Maybe more like in the Google Maps? I thinks it's pretty neatly done there.
  4. maybe some small and vague horizontal lines?? - quite optional
  5. maybe smaller corner radius of the bars??????????
  6. maybe let's put the whole chart into some greyish container? - to be more consistent with the parkings?

not about the chart: maybe we should also show current people counter and trend in the bottom drawer too? cause the app bar one is kinda in the background. In the parkings we have the current number too, so it would be more consistent.

Tell me what you think! Hopefully I don't interfere with your vision too much 🦔

Oh I didn't see your message.

@mikolaj-jalocha
Copy link
Member Author

Extremely fast visualization of your propositions:

  • imo gray background doesn't look good
  • certain hours (ie. each 3rd or even 4th) could be placed obliquely to the graph)
  • live counter is a good option, I will implement it
  • smaller corner radius's good idea
  • Do you think that left axis need title?
  • with 4 hours of scope (5 min intervals) chart is not readable. In following scenario prob. line chart'd be better.
chart

@tomasz-trela
Copy link
Member

Extremely fast visualization of your propositions:

  • imo gray background doesn't look good
  • certain hours (ie. each 3rd or even 4th) could be placed obliquely to the graph)
  • live counter is a good option, I will implement it
  • smaller corner radius's good idea
  • Do you think that left axis need title?
  • with 4 hours of scope (5 min intervals) chart is not readable. In following scenario prob. line chart'd be better.
chart

I think grey background looks bad, we don't need left title. Maybe change intervals to 10 minutes or try with line chart.

@mikolaj-jalocha mikolaj-jalocha changed the title SKS chart SKS chart - WIP ⚒️ Dec 1, 2024
@mikolaj-jalocha mikolaj-jalocha marked this pull request as draft December 1, 2024 20:12
@mikolaj-jalocha mikolaj-jalocha deleted the feat/sks-chart branch December 18, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

chore(sks-menu)/change color of arrows feat/ add sks chart
8 participants