-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SKS chart #458
SKS chart #458
Conversation
# Conflicts: # lib/features/sks_chart/data/models/sks_chart_data.dart # lib/features/sks_chart/data/repository/sks_chart_repository.dart # lib/features/sks_chart/presentation/sks_chart_screen.dart # lib/features/sks_people_live/presentation/widgets/sks_user_data_button.dart # lib/utils/datetime_utils.dart
…at/sks-chart # Conflicts: # lib/l10n/app_pl.arb
Hey! Didn't look more into this, but I have some quick thoughts/suggestions about the design:
not about the chart: maybe we should also show current people counter and trend in the bottom drawer too? cause the app bar one is kinda in the background. In the parkings we have the current number too, so it would be more consistent. Tell me what you think! Hopefully I don't interfere with your vision too much 🦔 |
I think vertical bars should be at right site. Similar to parkings. I think interval should be bigger. |
Oh I didn't see your message. |
# Conflicts: # lib/l10n/app_pl.arb
Massive glowup
#378