feat/news-demo - Issue #7 #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Octopus4344
previously approved these changes
Nov 25, 2024
src/lib/types.ts
Outdated
| export interface NewsProps { | ||
| id: number; | ||
| name: string; | ||
| date_created: Date; |
There was a problem hiding this comment.
API zwraca tu stringa, więc trzeba na to uwazac, w miare bezpiecznie moze byc jakos tak
Suggested change
| date_created: Date; | |
| date_created: Date | string; |
albo bezpieczniej
Suggested change
| date_created: Date; | |
| date_created: string; | |
| dateTime_created: Date; |
There was a problem hiding this comment.
W przyszlosci trzeba bedzie pewnie pomyslec o jakiejs sensownej obsludze bledow i paginacji, poki co mysle ze git
src/components/NewsDemo.tsx
Outdated
Comment on lines
12
to
14
| const newsSortedByDate = news.sort( | ||
| (a, b) => b.date_created.getTime() - a.date_created.getTime() | ||
| ); |
There was a problem hiding this comment.
Poki co wystarczy odwrocic liste, bo dane sa autonumerowanych indexach, przez zrobi sie liniowa zlozonosc
Suggested change
| const newsSortedByDate = news.sort( | |
| (a, b) => b.date_created.getTime() - a.date_created.getTime() | |
| ); | |
| const newsSortedByDate = news.reverse(); |
|
@Octopus4344 poprawiłem te rzeczy i dodalem basic paginację. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dodałem podstronkę zaciągającą i prowizorycznie wyświetlającą newsy z bazy.
Jesli chodzi o zmiany w types.ts i Navbar.tsx to głównie Prettier.