Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add automatical saving conversation in local storage #26

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: add automatical saving conversation in local storage #26

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
47ecb1e
feat(chatpage): Throw page not found error if chat is not in localSto…
mejsiejdev Dec 10, 2024
4d257a9
feat(textarea): Save prompt to localStorage on submit
mejsiejdev Dec 10, 2024
9432d30
feat(chatpage): Display saved prompt
mejsiejdev Dec 10, 2024
28ee3ba
refactor(chatpage): remove comment
mejsiejdev Dec 10, 2024
e3e2715
fix(chatpage): Fix `lint` errors
mejsiejdev Dec 10, 2024
9d0be30
feat(chatpage): Create `Chat` interface
mejsiejdev Dec 10, 2024
e3d9850
feat(chatpage): Store list of chats in localStorage
mejsiejdev Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/app/chat/[uuid]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
"use client";
//import { usePathname } from "next/navigation";

import { notFound, useParams } from "next/navigation";

interface Chat {
prompt: string;
}

export default function ConversationPage() {
/*
const pathname = usePathname(); // pathname = /chat/{uuid}
TODO load chat from local storage using uuid, if not found -> 404
*/
const parameters = useParams<{ uuid: string }>();

if (localStorage.getItem(parameters.uuid) === null) {
notFound();
}

const chat = JSON.parse(localStorage.getItem(parameters.uuid)!) as Chat;

return <div></div>;
return <div>{chat.prompt}</div>;
}
1 change: 1 addition & 0 deletions src/components/auto-resize-text-area.tsx
View file
Open in desktop
Copy link
Member

@maciejkrol18 maciejkrol18 Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The amount of code in the onClick callback can be reduced. Notice how this piece of code repeats two times:

localStorage.setItem(
  "chats",
  JSON.stringify([
    ...chats,
    { uuid: newUuid, prompt: text, recommendation: {} },
  ]),
);

I think it's always best to stick to the DRY principle (do not repeat yourself). Here's my take on the callback function - from 17 to 8 lines, and it works the same:

onClick={() => {
  setIsSubmitting(true);
  const newUuid = v4();  
  const chats = localStorage.getItem("chats") == null ? [] : JSON.parse(localStorage.getItem("chats")!) as Chat[]
  localStorage.setItem(
    "chats",
    JSON.stringify([
      ...chats,
      { uuid: newUuid, prompt: text, recommendation: {} },
    ]),
  );
  router.push(`/chat/${newUuid}`);
}}

I'll try my best to explain the thought process behind my changes:

const chats = localStorage.getItem("chats") == null ? [] : JSON.parse(localStorage.getItem("chats")!) as Chat[]

This line removes the need for the entire if block and utilizes a ternary operator instead. If a given local storage key doesn't exist then .getItem() method returns null, otherwise the json string, therefore we explicitly check whether .getItem("chats") is null (this also makes eslint rule @typescript/strict-boolean-expressions happy).

If true ("chats" are null)
it means no chats were saved yet, so we set "chats" variable to an empty array, therefore no type assertions are needed

If false ("chats" are not null)
it means at least one chat is saved, so we set "chats" variable to the parsed json string. Here we still use non-null assertion since typescript still thinks that .getItem("chats") can be null + we do a type assertion since JSON.parse() return type is any

localStorage.setItem(
  "chats",
  JSON.stringify([
    ...chats,
    { uuid: newUuid, prompt: text, recommendation: {} },
  ]),
);

And then we just set the "chats" local storage item to an array consisting of already existing chats and the newly created one. If "chats" variable is an empty array then we can still spread it without a problem.

This solution is compliant with our linter rules and passes all checks

EDIT: This is of course more of a nitpick and such refactor could be done later but since our project won't take that long and it isn't too complex we might as well tweak such things early on

Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export function AutoResizeTextArea({
setIsSubmitting(true);
const newUuid = v4();
//TODO adding conversation to localstorage there?
localStorage.setItem(newUuid, JSON.stringify({ prompt: text }));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need list of chats in local storage {"chats" : chat[]} where each one have uuid, prompt and other data related to response from api - it will allow us to generate sidebar items easily

router.push(`/chat/${newUuid}`);
}}
disabled={isSubmitting}
Expand Down
Loading