Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptació a ATR 3.0 #810

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Adaptació a ATR 3.0 #810

wants to merge 18 commits into from

Conversation

pedropote
Copy link
Contributor

@pedropote pedropote commented Feb 19, 2025

Objectiu

PR per adaptar-nos als canvis del ATR 3.0 del repo de GISCE
(PR anterior descartada #272)

Targeta on es demana o Incidència

https://somenergia.openproject.com/wp/682

Comportament antic

Comportament nou

Comprovacions

  • Hi ha testos
  • Reiniciar serveis
  • Actualitzar mòdul
  • Script de migració
  • Modifica traduccions

Copy link

github-actions bot commented Feb 19, 2025

Test Results

0 tests   - 121   0 ✅  - 120   0s ⏱️ -36s
0 suites  -   2   0 💤  -   1 
0 files    -   2   0 ❌ ±  0 

Results for commit e9653d1. ± Comparison against base commit 7a995e2.

♻️ This comment has been updated with latest results.

…utoconsum' because finally it remains 'autoconsumo'
Copy link
Member

@oriolpiera oriolpiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haurem de veure com ho fem Pere perquè quan vulguem passar tests, necessitarem passar-los amb la PR de gestionatr 3.0
gisce/gestionatr#258

…tionality. Remove this before merge.

Co-authored-by: Pau Boix <[email protected]>
@pedropote pedropote requested a review from oriolpiera February 27, 2025 13:37
'00': _(u"Sense autoconsum"), # Sin autoconsumo
'0C': _(u"Baixa com a membre d'autoconsum col·lectiu"), # Baja como miembro de autoconsumo colectivo
}
autoconsum_text = TABLA_133_dict[cd.autoconsum] if cd.autoconsum in TABLA_133_dict else _("")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sobre la nova taula, mira't aquesta PR:
#641

Vam moure la taula a som_polissa/giscedata_cups.py per poder-la importar des d'un mako i no tenir-la definida a més d'un lloc.

Suposo que seria una cosa així:

Suggested change
autoconsum_text = TABLA_133_dict[cd.autoconsum] if cd.autoconsum in TABLA_133_dict else _("")
from som_polissa.giscedata_cups import TABLA_133_dict
autoconsum_text = TABLA_133_dict[cd.autoconsum] if cd.autoconsum in TABLA_133_dict else _("")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants