Deprecated warning on old import-once and import-multiple #126

src/main/java/com/github/sommeri/less4j/core/parser/ASTBuilderSwitch.java

@@ -1072,9 +1072,11 @@ public Import handleImport(HiddenTokenAwareTree token) {
       break;
     case LessLexer.IMPORT_ONCE_SYM:
       result.setMultiplicity(Import.ImportMultiplicity.IMPORT_ONCE);
+      problemsHandler.deprecatedImportOnce(result);
       break;
     case LessLexer.IMPORT_MULTIPLE_SYM:
       result.setMultiplicity(Import.ImportMultiplicity.IMPORT_MULTIPLE);
+      problemsHandler.deprecatedImportMultiple(result);
       break;
     default:
       throw new BugHappened(GRAMMAR_MISMATCH, token);

src/main/java/com/github/sommeri/less4j/core/problems/ProblemsHandler.java

@@ -131,6 +131,14 @@ public void mixinsCycle(List<MixinReference> cycle) {
     collector.addError(new CompilationError(cycle.get(0), "Cyclic references among mixins: " + printer.toMixinReferencesString(cycle)));
   }
 
+  public void deprecatedImportOnce(Import errorNode) {
+    collector.addWarning(new CompilationWarning(errorNode, "`@import-once <url>` have been deprecated. Use `@import (once) <url>` instead. Input file is less.js incompatible."));
+  }
+
+  public void deprecatedImportMultiple(Import errorNode) {
+    collector.addWarning(new CompilationWarning(errorNode, "`@import-multiple <url>` have been deprecated. Use `@import (multiple) <url>` instead. Input file is less.js incompatible."));
+  }
+
   public void deprecatedSyntaxEscapedSelector(EscapedSelector errorNode) {
     collector.addWarning(new CompilationWarning(errorNode, "Selector fragment (~" + errorNode.getQuoteType() + errorNode.getValue() + errorNode.getQuoteType() + ") uses deprecated (~\"escaped-selector\") syntax. Use selector interpolation @{variableName} instead."));
   }

src/test/resources/compile-basic-features/import/import-deep-incorrect.less

@@ -1,4 +1,4 @@
-@import-once url(import/import-deep-incorrect.less);
+@import (once) url(import/import-deep-incorrect.less);
 @variable: value;
 h1 {
   content: ~"@{variable}";

src/test/resources/compile-basic-features/import/import-file-not-exists.css

@@ -1,4 +1,5 @@
 @import url(somewhere/this-file-does-not-exists.less);
+@import url(somewhere/this-file-does-not-exists-old-syntax.less);
 .class {
   padding: 2 2 2 2;
 }

src/test/resources/compile-basic-features/import/import-file-not-exists.err

@@ -1,2 +1,5 @@
+Warnings produced by compilation of testCase
+WARNING 2:1 `@import-once <url>` have been deprecated. Use `@import (once) <url>` instead. Input file is less.js incompatible.
 Errors produced by compilation of testCase
 ERROR 1:1 The file somewhere/this-file-does-not-exists.less does not exist.
+ERROR 2:1 The file somewhere/this-file-does-not-exists-old-syntax.less does not exist.

src/test/resources/compile-basic-features/import/import-file-not-exists.less

@@ -1,4 +1,5 @@
-@import-once url(somewhere/this-file-does-not-exists.less);
+@import (once) url(somewhere/this-file-does-not-exists.less);
+@import-once url(somewhere/this-file-does-not-exists-old-syntax.less);
 .class {
   padding: 2 2 2 2;
 }

src/test/resources/compile-basic-features/import/import-interpolated-complicated.less

@@ -1,14 +1,14 @@
 @filename: "chained-reference-import-";
 @filename2: "chained-reference-import-";
-@import-multiple "import/@{filename}1.less";
+@import (multiple) "import/@{filename}1.less";
 .mainMixin {
   color: green;
 }
 .see-global {
-  @import-multiple url("import/@{filename}2.less");
+  @import (multiple) url("import/@{filename}2.less");
 }
 .redefined {
-  @import-multiple url('import/@{filename}import-2.less');
+  @import (multiple) url('import/@{filename}import-2.less');
   @filename: "chained-reference-";
 }
 @definitelyLast: 3;

src/test/resources/compile-basic-features/import/import-interpolated-dependence.less

@@ -1,10 +1,10 @@
 @variable: "import/imports-dependence-1";
-@import-multiple "@{variable}.less";
+@import (multiple) "@{variable}.less";
 .mainMixin {
   color: @another;
 }
 .see-global {
-  @import-multiple "@{variable}.less";
+  @import (multiple) "@{variable}.less";
 }
-@import-multiple "@{variable}.less";
+@import (multiple) "@{variable}.less";
 @definitelyLast: 3;

src/test/resources/compile-basic-features/import/import-old-media-queries.err

@@ -0,0 +1,3 @@
+Warnings produced by compilation of testCase
+WARNING 1:1 `@import-multiple <url>` have been deprecated. Use `@import (multiple) <url>` instead. Input file is less.js incompatible.
+WARNING 2:1 `@import-multiple <url>` have been deprecated. Use `@import (multiple) <url>` instead. Input file is less.js incompatible.

src/test/resources/compile-basic-features/import/import-old-multiplicity-css-files.err

@@ -0,0 +1,11 @@
+Warnings produced by compilation of testCase
+WARNING 11:1 `@import-once <url>` have been deprecated. Use `@import (once) <url>` instead. Input file is less.js incompatible.
+WARNING 12:1 `@import-once <url>` have been deprecated. Use `@import (once) <url>` instead. Input file is less.js incompatible.
+WARNING 13:1 `@import-once <url>` have been deprecated. Use `@import (once) <url>` instead. Input file is less.js incompatible.
+WARNING 14:1 `@import-once <url>` have been deprecated. Use `@import (once) <url>` instead. Input file is less.js incompatible.
+WARNING 15:1 `@import-once <url>` have been deprecated. Use `@import (once) <url>` instead. Input file is less.js incompatible.
+WARNING 17:1 `@import-multiple <url>` have been deprecated. Use `@import (multiple) <url>` instead. Input file is less.js incompatible.
+WARNING 18:1 `@import-multiple <url>` have been deprecated. Use `@import (multiple) <url>` instead. Input file is less.js incompatible.
+WARNING 19:1 `@import-multiple <url>` have been deprecated. Use `@import (multiple) <url>` instead. Input file is less.js incompatible.
+WARNING 20:1 `@import-multiple <url>` have been deprecated. Use `@import (multiple) <url>` instead. Input file is less.js incompatible.
+WARNING 21:1 `@import-multiple <url>` have been deprecated. Use `@import (multiple) <url>` instead. Input file is less.js incompatible.

src/test/resources/compile-basic-features/import/import-once-order.less

@@ -1,5 +1,5 @@
-@import-once "import/chained-import-1.less";
+@import (once) "import/chained-import-1.less";
 h1 {
   color: green;
 }
-@import-once "import/chained-import-2.less";
+@import (once) "import/chained-import-2.less";

src/test/resources/compile-basic-features/import/import-syntactically-incorrect-unclosed-ruleset.less

@@ -1,4 +1,4 @@
-@import-once url(import/syntactically-incorrect-unclosed-ruleset.less);
+@import (once) url(import/syntactically-incorrect-unclosed-ruleset.less);
 @variable: value;
 h1 {
   content: ~"@{variable}";

src/test/resources/compile-basic-features/import/import-syntactically-incorrect-wrong-variable.less

@@ -1,4 +1,4 @@
-@import-once url(import/syntactically-incorrect-wrong-variable.less);
+@import (once) url(import/syntactically-incorrect-wrong-variable.less);
 @variable: value;
 h1 {
   content: ~"@{variable}";

src/test/resources/compile-basic-features/import/import-types-combinations.less

@@ -1,5 +1,5 @@
 @import "import/one-simple-ruleset.less";
 @import "import/one-simple-ruleset.less";
-@import-once "import/one-simple-ruleset.less";
-@import-once "import/one-simple-ruleset.less";
-//@import-multiple "import/one-simple-ruleset.less";
+@import (once) "import/one-simple-ruleset.less";
+@import (once) "import/one-simple-ruleset.less";
+//@import (multiple) "import/one-simple-ruleset.less";

src/test/resources/compile-basic-features/import/import-variables-and-mixins-chained.less

@@ -6,7 +6,7 @@
   #space .mixin;
   @fromImporter: "h1";
 }
-@import-multiple "import/import-namespaces-and-mixins.less";
+@import (multiple) "import/import-namespaces-and-mixins.less";
 
 :after {
   .mixin;

src/test/resources/compile-basic-features/import/import-variables-and-mixins.less

@@ -1,4 +1,4 @@
-@import-multiple "import/namespaces-and-mixins.less";
+@import (multiple) "import/namespaces-and-mixins.less";
 
 h1 {
   .mixin;

src/test/resources/compile-basic-features/import/import/chained-import-1.less

@@ -1,4 +1,4 @@
 chained-import-1 {
   content: ~"chained-import-1";
 }
-@import-once "chained-import-2.less";
+@import (once) "chained-import-2.less";

src/test/resources/compile-basic-features/import/import/chained-reference-import-1.less

@@ -1,4 +1,4 @@
 chained-import-1 {
   content: ~"chained-referenced-import-1";
 }
-@import-multiple "@{filename2}2.less";
+@import (multiple) "@{filename2}2.less";

src/test/resources/compile-basic-features/import/import/import-namespaces-and-mixins.less

@@ -1 +1 @@
-@import-multiple "namespaces-and-mixins.less";
+@import (multiple) "namespaces-and-mixins.less";

src/test/resources/compile-basic-features/import/imports-depend-on-each-other.less

@@ -1,2 +1,2 @@
-@import-once "import/cyclic-1.less";
-@import-once "import/cyclic-2.less";
+@import (once) "import/cyclic-1.less";
+@import (once) "import/cyclic-2.less";

src/test/resources/compile-basic-features/import/unknown-input-file/import-types-combinations.err

@@ -1,7 +1,7 @@
 Warnings produced by compilation of testCase
 WARNING 4:9 Attempt to import less file with an unknown compiled file location. Import statement left unchanged.
 WARNING 5:9 Attempt to import less file with an unknown compiled file location. Import statement left unchanged.
-WARNING 6:14 Attempt to import less file with an unknown compiled file location. Import statement left unchanged.
-WARNING 7:14 Attempt to import less file with an unknown compiled file location. Import statement left unchanged.
-WARNING 8:18 Attempt to import less file with an unknown compiled file location. Import statement left unchanged.
-WARNING 9:18 Attempt to import less file with an unknown compiled file location. Import statement left unchanged.
+WARNING 6:16 Attempt to import less file with an unknown compiled file location. Import statement left unchanged.
+WARNING 7:16 Attempt to import less file with an unknown compiled file location. Import statement left unchanged.
+WARNING 8:20 Attempt to import less file with an unknown compiled file location. Import statement left unchanged.
+WARNING 9:20 Attempt to import less file with an unknown compiled file location. Import statement left unchanged.

src/test/resources/compile-basic-features/import/unknown-input-file/import-types-combinations.less

@@ -3,7 +3,7 @@ h1 {
 }
 @import "import\one-simple-ruleset.less";
 @import "import\one-simple-ruleset.less";
-@import-once "import\one-simple-ruleset.less";
-@import-once "import\one-simple-ruleset.less";
-@import-multiple "import\one-simple-ruleset.less";
-@import-multiple "import\one-simple-ruleset.less";
+@import (once) "import\one-simple-ruleset.less";
+@import (once) "import\one-simple-ruleset.less";
+@import (multiple) "import\one-simple-ruleset.less";
+@import (multiple) "import\one-simple-ruleset.less";

src/test/resources/less.js-v1.3.3/less/import-once.less

@@ -1,4 +1,4 @@
-@import-once "import/import-once-test-c";
-@import-once "import/import-once-test-c";
-//@import-once "import/import-once-test-c.less";
-//@import-once "import/deeper/import-once-test-a";
+@import (once) "import/import-once-test-c";
+@import (once) "import/import-once-test-c";
+//@import (once) "import/import-once-test-c.less";
+//@import (once) "import/deeper/import-once-test-a";

src/test/resources/source-map/content/import/chained-import-1.less

@@ -1,4 +1,4 @@
 .chained-import-1 {
   content: ~"chained-import-1";
 }
-@import-once "chained-import-2.less";
+@import (once) "chained-import-2.less";

src/test/resources/source-map/content/sm-imports.less

@@ -4,8 +4,8 @@
  * - last long
  *
  */
-@import-once "import/chained-import-1.less";
+@import (once) "import/chained-import-1.less";
 .maintitle {
   color: green;
 }
-@import-once "import/chained-import-2.less";
+@import (once) "import/chained-import-2.less";