Clean up Volcano Plotting functionality -> particularly plotVolcanoHTML()
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unified the params for `plotVolcanoHTML()` and `plotVolcano()` - used param inheritance to ensure common param definitions - fixed and improved the examples in the docs for `plotVolcanoHTML()` - removed default `FC` and `p.value` arguments - changed `p.vec` -> `p.value` param name - changed `target.labels` -> `labels` param name to match - changed `apt.data` -> `tbl` param name to match SomaDataIO consistency. Only necessary for `plotVolcanoHTML.stat_table()` - de-emphasize the `stat_table` S3 method; not commonly used externally as part of SL internal toolkit - added new helper `.volcano_cols()` function to map colors/names - updated unit tests as necessary - updated SomaPlotr.Rmd vignette arguments as necessary - fixes #8, #9
stufield
force-pushed
the
remove-apt-data-param
branch
2 times, most recently
from
d8214d6 to
4f000eb
Compare
- added a `@family` tag to the docs
stufield
force-pushed
the
remove-apt-data-param
branch
from
4f000eb to
f2e05b6
Compare
amanda-hi
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of Pull Request
Many changes and clean up for Volcano plotting functionality, including param consistency and documentation.
Fixes #8, #9
Choose reviewer(s)