SONAR-24186 improve file ownership #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jCOTINEAU
changed the title
jCOTINEAU
force-pushed
the
feature/jc/SONAR-24186-improve-file-ownership
branch
from
6834c73 to
5b5dad3
Compare
jCOTINEAU
force-pushed
the
feature/jc/SONAR-24186-improve-file-ownership
branch
from
5b5dad3 to
ec4e518
Compare
jCOTINEAU
changed the title
jCOTINEAU
force-pushed
the
feature/jc/SONAR-24186-improve-file-ownership
branch
from
f6d85ec to
17ddda2
Compare
jCOTINEAU
force-pushed
the
feature/jc/SONAR-24186-improve-file-ownership
branch
from
17ddda2 to
89f8cdd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONAR-24186
We identified that we were not covering all options for runAsUser and runAsGroup in kubernetes context.
By adding ownership of files to sonarqube user we are compatible with both those workflow:
the current openshift behavior which is anyUid and gid=0
More classic use case were people rely on UID of the image (1000 in our case) but with gid!=0
Those two workflow will work as permissions are assigned to both owner and group.