SONARJAVA-4722 Implement S6857: SpEL expression should have valid syntax

Co-authored-by: Dorian Burihabwa <[email protected]>
SonarSource · Dec 11, 2023 · 2d20bd1 · 2d20bd1
1 parent 8f7ae0f
commit 2d20bd1
Show file tree

Hide file tree

Showing 22 changed files with 848 additions and 16 deletions.
diff --git a/its/autoscan/src/test/resources/autoscan/autoscan-diff-by-rules.json b/its/autoscan/src/test/resources/autoscan/autoscan-diff-by-rules.json
@@ -2939,6 +2939,12 @@
     "falseNegatives": 2,
     "falsePositives": 0
   },
+  {
+    "ruleKey": "S6857",
+    "hasTruePositives": false,
+    "falseNegatives": 57,
+    "falsePositives": 0
+  },
   {
     "ruleKey": "S6862",
     "hasTruePositives": false,

diff --git a/its/autoscan/src/test/resources/autoscan/diffs/diff_S1874.json b/its/autoscan/src/test/resources/autoscan/diffs/diff_S1874.json
@@ -1,6 +1,6 @@
 {
   "ruleKey": "S1874",
   "hasTruePositives": true,
-  "falseNegatives": 103,
+  "falseNegatives": 102,
   "falsePositives": 0
-}
+}
diff --git a/its/autoscan/src/test/resources/autoscan/diffs/diff_S2259.json b/its/autoscan/src/test/resources/autoscan/diffs/diff_S2259.json
@@ -1,6 +1,6 @@
 {
   "ruleKey": "S2259",
   "hasTruePositives": true,
-  "falseNegatives": 4,
+  "falseNegatives": 3,
   "falsePositives": 0
 }
diff --git a/its/autoscan/src/test/resources/autoscan/diffs/diff_S2583.json b/its/autoscan/src/test/resources/autoscan/diffs/diff_S2583.json
@@ -1,6 +1,6 @@
 {
   "ruleKey": "S2583",
   "hasTruePositives": true,
-  "falseNegatives": 21,
+  "falseNegatives": 12,
   "falsePositives": 0
 }
diff --git a/its/autoscan/src/test/resources/autoscan/diffs/diff_S2589.json b/its/autoscan/src/test/resources/autoscan/diffs/diff_S2589.json
@@ -1,6 +1,6 @@
 {
   "ruleKey": "S2589",
   "hasTruePositives": true,
-  "falseNegatives": 5,
+  "falseNegatives": 3,
   "falsePositives": 0
 }
diff --git a/its/autoscan/src/test/resources/autoscan/diffs/diff_S2637.json b/its/autoscan/src/test/resources/autoscan/diffs/diff_S2637.json
@@ -1,6 +1,6 @@
 {
   "ruleKey": "S2637",
   "hasTruePositives": true,
-  "falseNegatives": 21,
+  "falseNegatives": 20,
   "falsePositives": 0
 }
diff --git a/its/autoscan/src/test/resources/autoscan/diffs/diff_S3416.json b/its/autoscan/src/test/resources/autoscan/diffs/diff_S3416.json
@@ -1,6 +1,6 @@
 {
   "ruleKey": "S3416",
   "hasTruePositives": true,
-  "falseNegatives": 6,
+  "falseNegatives": 5,
   "falsePositives": 0
 }
diff --git a/its/autoscan/src/test/resources/autoscan/diffs/diff_S3516.json b/its/autoscan/src/test/resources/autoscan/diffs/diff_S3516.json
@@ -1,6 +1,6 @@
 {
   "ruleKey": "S3516",
   "hasTruePositives": true,
-  "falseNegatives": 11,
+  "falseNegatives": 6,
   "falsePositives": 0
 }
diff --git a/its/autoscan/src/test/resources/autoscan/diffs/diff_S4449.json b/its/autoscan/src/test/resources/autoscan/diffs/diff_S4449.json
@@ -1,6 +1,6 @@
 {
   "ruleKey": "S4449",
-  "hasTruePositives": false,
-  "falseNegatives": 27,
+  "hasTruePositives": true,
+  "falseNegatives": 23,
   "falsePositives": 0
 }
diff --git a/its/autoscan/src/test/resources/autoscan/diffs/diff_S4790.json b/its/autoscan/src/test/resources/autoscan/diffs/diff_S4790.json
@@ -1,6 +1,6 @@
 {
   "ruleKey": "S4790",
   "hasTruePositives": true,
-  "falseNegatives": 37,
+  "falseNegatives": 31,
   "falsePositives": 0
 }
diff --git a/its/autoscan/src/test/resources/autoscan/diffs/diff_S6804.json b/its/autoscan/src/test/resources/autoscan/diffs/diff_S6804.json
@@ -1,6 +1,6 @@
 {
   "ruleKey": "S6804",
   "hasTruePositives": false,
-  "falseNegatives": 12,
+  "falseNegatives": 48,
   "falsePositives": 0
-}
+}
diff --git a/its/autoscan/src/test/resources/autoscan/diffs/diff_S6857.json b/its/autoscan/src/test/resources/autoscan/diffs/diff_S6857.json
@@ -0,0 +1,6 @@
+{
+  "ruleKey": "S6857",
+  "hasTruePositives": false,
+  "falseNegatives": 68,
+  "falsePositives": 0
+}