Skip to content

Commit

Permalink
SONARJAVA-5173 Fix broken docs for SQ_10_6. (#4922)
Browse files Browse the repository at this point in the history
We were not able to compile some tests, because
org.sonar.api.testfixtures.log.LogTester moved to
sonar-plugin-api-test-fixtures.

Tested with `mvn clean install -f pom_SQ_10_6_LATEST.xml`

We also fix the CI to run the above command automatically.
This was tested by running CI against a bad change.
  • Loading branch information
tomasz-tylenda-sonarsource authored Nov 12, 2024
1 parent f21c217 commit 3456a1c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .cirrus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ test_analyze_task:
- source cirrus-env BUILD
# ignore duplications in the SE engine plugin, as it will be moved away from sonar-java at some point
- PULL_REQUEST_SHA=$GIT_SHA1 regular_mvn_build_deploy_analyze -P-deploy-sonarsource,-release,-sign -Dmaven.deploy.skip=true -Dsonar.analysisCache.enabled=true -Dsonar.cpd.exclusions=java-symbolic-execution/**
- cd docs/java-custom-rules-example
- mvn clean package -f pom_SQ_10_6_LATEST.xml --batch-mode
- cd "${CIRRUS_WORKING_DIR}"
- ./check-license-compliance.sh
cleanup_before_cache_script: cleanup_maven_repository

Expand Down
10 changes: 9 additions & 1 deletion docs/java-custom-rules-example/pom_SQ_10_6_LATEST.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
<description>Java Custom Rules Example for SonarQube</description>

<properties>
<sonar.plugin.api.version>9.14.0.375</sonar.plugin.api.version>
<!-- TODO: Next time bump it up to the LTS version. -->
<sonar.plugin.api.version>10.7.0.2191</sonar.plugin.api.version>
<sonarjava.version>8.0.1.36337</sonarjava.version>
<!-- Don't forget to update this version of JaCoCo -->
<jacoco.version>0.8.10</jacoco.version>
Expand Down Expand Up @@ -67,6 +68,13 @@
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.sonarsource.api.plugin</groupId>
<artifactId>sonar-plugin-api-test-fixtures</artifactId>
<version>${sonar.plugin.api.version}</version>
<scope>test</scope>
</dependency>

<!-- version to be specified manually -->
<dependency>
<groupId>org.junit.jupiter</groupId>
Expand Down

0 comments on commit 3456a1c

Please sign in to comment.