SONARJAVA-4726 (external contribution) fix crash in SelfAssignementCheck

Author: gtoison <[email protected]>
SonarSource · Dec 13, 2023 · 4248c48 · 4248c48
1 parent 252ade8
commit 4248c48
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/java-checks-test-sources/default/src/main/java/checks/SelfAssignementCheck.java b/java-checks-test-sources/default/src/main/java/checks/SelfAssignementCheck.java
@@ -1,6 +1,12 @@
 package checks;
 
 class SelfAssignementCheck {
+  static int staticField = 0;
+
+  static {
+    staticField = staticField;  // Noncompliant
+  }
+
   int a, c = 0;
   int[] b = {0};
 

diff --git a/java-checks/src/main/java/org/sonar/java/checks/SelfAssignementCheck.java b/java-checks/src/main/java/org/sonar/java/checks/SelfAssignementCheck.java
@@ -90,7 +90,7 @@ private static JavaQuickFix getQuickFix(AssignmentExpressionTree tree) {
     MethodTree methodParent = (MethodTree) ExpressionUtils.getParentOfType(tree, Tree.Kind.METHOD, Tree.Kind.CONSTRUCTOR);
     String name = getName(tree.variable());
 
-    boolean isMethodParameter = methodParent.parameters().stream()
+    boolean isMethodParameter = methodParent != null && methodParent.parameters().stream()
       .map(p -> p.simpleName().name())
       .anyMatch(p -> p.equals(name));