Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARJAVA-5184 Suppress boxed Boolean warnings on @NonNull parameters. #4931

Merged
merged 2 commits into from
Nov 21, 2024
Merged

SONARJAVA-5184 Suppress boxed Boolean warnings on @NonNull parameters. #4931

merged 2 commits into from
Nov 21, 2024

Conversation

tomasz-tylenda-sonarsource
Copy link
Contributor

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource commented Nov 18, 2024 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title SONARJAVA-5184 Suppress boxed Boolean warnings on @NonNull parameters. SONARJAVA-5184 Suppress boxed Boolean warnings on @NonNull parameters. Nov 18, 2024
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource force-pushed the tt/boxed-boolean-lambda branch 2 times, most recently from 9c1008c to 1049b38 Compare November 19, 2024 16:52
leonardo-pilastri-sonarsource
leonardo-pilastri-sonarsource approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just left a comment on some useless parenthesis, but it might be debatable if they make the code more readable or not. I would personally remove them

java-checks/src/main/java/org/sonar/java/checks/BoxedBooleanExpressionsCheck.java Outdated Show resolved Hide resolved
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource merged commit 6144892 into master Nov 21, 2024
15 checks passed
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource deleted the tt/boxed-boolean-lambda branch November 21, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasz-tylenda-sonarsource @leonardo-pilastri-sonarsource