Fix findReceiverScopeFunctionLiteral to only resolve scope functions …

…if their argument is used
SonarSource · Nov 28, 2024 · 71f5ded · 71f5ded
1 parent 0b5895f
commit 71f5ded
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/kotlin-checks-test-sources/src/main/kotlin/checks/CollectionInappropriateCallsCheckSample.kt b/kotlin-checks-test-sources/src/main/kotlin/checks/CollectionInappropriateCallsCheckSample.kt
@@ -108,4 +108,15 @@ class CollectionInappropriateCallsCheckSample {
         intArray.lastIndexOf(10)
     }
 
+    // The collection type was resolved incorrectly and led to java.lang.IndexOutOfBoundsException
+    // We should only resolve let/apply/with if its argument was used as a receiver
+    fun bugWithLetApplyWithResolution(s: String?, params: Map<String, Array<String>>) = s?.let {
+        val params1 = params.get("ABC")!!
+        mutableListOf(params1.indexOf(it))
+    }
+
+    fun bugWithLetApplyWithResolution(s: String?, params: Array<String>?) = params?.let {
+        mutableListOf(it.indexOf(s))
+    }
+
 }
diff --git a/sonar-kotlin-api/src/main/java/org/sonarsource/kotlin/api/checks/ApiExtensions.kt b/sonar-kotlin-api/src/main/java/org/sonarsource/kotlin/api/checks/ApiExtensions.kt
@@ -380,9 +380,12 @@ private fun KaImplicitReceiverValue.findReceiverScopeFunctionLiteral(
 @Rewritten
 private fun KtReferenceExpression.findReceiverScopeFunctionLiteral(): KtFunctionLiteral? =
     analyze {
-        this@findReceiverScopeFunctionLiteral.mainReference.resolveToSymbol()?.containingSymbol?.findFunctionLiteral(
-            this@findReceiverScopeFunctionLiteral
-        )
+        when (val resolvedSymbol = this@findReceiverScopeFunctionLiteral.mainReference.resolveToSymbol()) {
+                        is KaValueParameterSymbol -> resolvedSymbol.containingSymbol?.findFunctionLiteral(
+                            this@findReceiverScopeFunctionLiteral
+                        )
+            else -> null
+        }
     }