SONARKT-400 Migrate UnusedDeferredResultCheck to kotlin-analysis-api

SonarSource · Dec 2, 2024 · 75018a6 · 75018a6
1 parent 643b3f7
commit 75018a6
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/UnusedDeferredResultCheck.kt b/sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/UnusedDeferredResultCheck.kt
@@ -16,25 +16,23 @@
  */
 package org.sonarsource.kotlin.checks
 
+import org.jetbrains.kotlin.name.ClassId
 import org.jetbrains.kotlin.psi.KtCallExpression
-import org.jetbrains.kotlin.resolve.bindingContextUtil.isUsedAsStatement
 import org.sonar.check.Rule
 import org.sonarsource.kotlin.api.checks.AbstractCheck
 import org.sonarsource.kotlin.api.checks.DEFERRED_FQN
-import org.sonarsource.kotlin.api.checks.expressionTypeFqn
 import org.sonarsource.kotlin.api.frontend.KotlinFileContext
+import org.sonarsource.kotlin.api.visiting.withKaSession
 
-@org.sonarsource.kotlin.api.frontend.K1only
 @Rule(key = "S6315")
 class UnusedDeferredResultCheck : AbstractCheck() {
 
-    override fun visitCallExpression(expression: KtCallExpression, context: KotlinFileContext) {
-        val bindingContext = context.bindingContext
-        if (expression.expressionTypeFqn(bindingContext) == DEFERRED_FQN
-            && expression.isUsedAsStatement(bindingContext)
-        ) {
+    private val deferredFqn = ClassId.fromString(DEFERRED_FQN.replace('.', '/'))
+
+    override fun visitCallExpression(expression: KtCallExpression, context: KotlinFileContext) = withKaSession {
+        if (expression.expressionType!!.isClassType(deferredFqn)
+            && !expression.isUsedAsExpression) {
             context.reportIssue(expression.calleeExpression!!, """This function returns "Deferred", but its result is never used.""")
-            return
         }
     }
 }