SLCORE-1149 Reflect PR review comments

SonarSource · Feb 3, 2025 · c318d46 · c318d46
1 parent 58ef518
commit c318d46
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/...va/org/sonarsource/sonarlint/core/analysis/container/analysis/sensor/SensorsExecutor.java b/...va/org/sonarsource/sonarlint/core/analysis/container/analysis/sensor/SensorsExecutor.java
@@ -55,12 +55,12 @@ public class SensorsExecutor {
   @Nullable
   private final Trace trace;
 
-  public SensorsExecutor(DefaultSensorContext context, SensorOptimizer sensorOptimizer, ProgressMonitor progress, @Nullable Trace trace, Optional<List<ProjectSensor>> sensors) {
+  public SensorsExecutor(DefaultSensorContext context, SensorOptimizer sensorOptimizer, ProgressMonitor progress, Optional<Trace> trace, Optional<List<ProjectSensor>> sensors) {
     this.context = context;
     this.sensors = sensors.orElse(List.of());
     this.sensorOptimizer = sensorOptimizer;
     this.progress = progress;
-    this.trace = trace;
+    this.trace = trace.orElse(null);
   }
 
   public void execute() {

diff --git a/...g/sonarsource/sonarlint/core/analysis/container/analysis/sensor/SensorsExecutorTests.java b/...g/sonarsource/sonarlint/core/analysis/container/analysis/sensor/SensorsExecutorTests.java
@@ -68,7 +68,7 @@ public String toString() {
   void testThrowingSensorShouldBeLogged() {
     var sensorOptimizer = mock(SensorOptimizer.class);
     when(sensorOptimizer.shouldExecute(any())).thenReturn(true);
-    var executor = new SensorsExecutor(null, sensorOptimizer, new ProgressMonitor(null), null, Optional.of(List.of(new ThrowingSensor())));
+    var executor = new SensorsExecutor(null, sensorOptimizer, new ProgressMonitor(null), Optional.empty(), Optional.of(List.of(new ThrowingSensor())));
 
     executor.execute();
 
@@ -84,7 +84,7 @@ void shouldRunGlobalSensorLast() {
     var globalSensor = new GlobalSensor();
     var oldGlobalSensor = new OldGlobalSensor();
 
-    var executor = new SensorsExecutor(null, sensorOptimizer, new ProgressMonitor(null), null, Optional.of(List.of(globalSensor, regularSensor, oldGlobalSensor)));
+    var executor = new SensorsExecutor(null, sensorOptimizer, new ProgressMonitor(null), Optional.empty(), Optional.of(List.of(globalSensor, regularSensor, oldGlobalSensor)));
 
     executor.execute();
 

diff --git a/...ns/src/main/java/org/sonarsource/sonarlint/core/commons/monitoring/MonitoringService.java b/...ns/src/main/java/org/sonarsource/sonarlint/core/commons/monitoring/MonitoringService.java
@@ -82,8 +82,11 @@ private static String getDsn() {
   private static double getTracesSampleRate() {
     try {
       var sampleRateFromSystemProperty = System.getProperty(TRACES_SAMPLE_RATE_PROPERTY);
-      return Double.parseDouble(sampleRateFromSystemProperty);
+      var parsedSampleRate = Double.parseDouble(sampleRateFromSystemProperty);
+      LOG.debug("Overriding trace sample rate with value from system property: {}", parsedSampleRate);
+      return parsedSampleRate;
     } catch (RuntimeException e) {
+      LOG.debug("Using default trace sample rate: {}", TRACES_SAMPLE_RATE_DEFAULT);
       return TRACES_SAMPLE_RATE_DEFAULT;
     }
   }