Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new issues #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Create new issues #2

wants to merge 3 commits into from

Conversation

ricardogarfe
Copy link
Member

No description provided.

@@ -1,5 +1,7 @@
package com.example.geekshubs;

import java.util.Map;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Remove this unused import 'java.util.Map'. rule

@@ -10,5 +12,6 @@ public void nothingToDo() {
System.out.println("Nothing to do here");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this use of System.out or System.err by a logger. rule

@@ -10,5 +12,6 @@ public void nothingToDo() {
System.out.println("Nothing to do here");
System.out.println("Nothing to do here");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this use of System.out or System.err by a logger. rule

@sonargeekshubs
Copy link
Contributor

SonarQube analysis reported 10 issues

  • CRITICAL 1 critical
  • MAJOR 8 major
  • MINOR 1 minor

Watch the comments in this conversation to review them.

5 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL VoidFeature.java#L8: Define a constant instead of duplicating this literal "Nothing to do here" 8 times. rule
  2. MAJOR VoidFeature.java#L8: Replace this use of System.out or System.err by a logger. rule
  3. MAJOR VoidFeature.java#L9: Replace this use of System.out or System.err by a logger. rule
  4. MAJOR VoidFeature.java#L10: Replace this use of System.out or System.err by a logger. rule
  5. MAJOR VoidFeature.java#L11: Replace this use of System.out or System.err by a logger. rule

@@ -10,5 +12,6 @@ public void nothingToDo() {
System.out.println("Nothing to do here");
System.out.println("Nothing to do here");
System.out.println("Nothing to do here");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this use of System.out or System.err by a logger. rule

@@ -10,5 +12,6 @@ public void nothingToDo() {
System.out.println("Nothing to do here");
System.out.println("Nothing to do here");
System.out.println("Nothing to do here");
System.out.println("Nothing to do here");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this use of System.out or System.err by a logger. rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants