fix: use close event to resolve process.exec instead of exti

Doc says stdout/stderr can stil be open even after process exit and that can lead to loss of output text Signed-off-by: Denis Golovin <[email protected]>
SoniaSandler · Oct 30, 2024 · 1e43289 · 1e43289
1 parent a96e101
commit 1e43289
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/packages/main/src/plugin/util/exec.spec.ts b/packages/main/src/plugin/util/exec.spec.ts
@@ -78,7 +78,7 @@ describe('exec', () => {
       stdout: { on, setEncoding: setEncodingMock },
       stderr: { on, setEncoding: setEncodingMock },
       on: vi.fn().mockImplementation((event: string, cb: (arg0: number) => void) => {
-        if (event === 'exit') {
+        if (event === 'close') {
           cb(0);
         }
       }),
@@ -106,7 +106,7 @@ describe('exec', () => {
       stdout: { on, setEncoding: setEncodingMock },
       stderr: { on, setEncoding: setEncodingMock },
       on: vi.fn().mockImplementation((event: string, cb: (arg0: number) => void) => {
-        if (event === 'exit') {
+        if (event === 'close') {
           cb(0);
         }
       }),
@@ -133,7 +133,7 @@ describe('exec', () => {
       stdout: { on, setEncoding: setEncodingMock },
       stderr: { on, setEncoding: setEncodingMock },
       on: vi.fn().mockImplementation((event: string, cb: (arg0: number) => void) => {
-        if (event === 'exit') {
+        if (event === 'close') {
           cb(1);
         }
       }),
@@ -246,7 +246,7 @@ describe('exec', () => {
       stdout: { on, setEncoding: setEncodingMock },
       stderr: { on, setEncoding: setEncodingMock },
       on: vi.fn().mockImplementation((event: string, cb: (arg0: number) => void) => {
-        if (event === 'exit') {
+        if (event === 'close') {
           cb(0);
         }
       }),
@@ -283,7 +283,7 @@ describe('exec', () => {
       stdout: { on, setEncoding: setEncodingMock },
       stderr: { on, setEncoding: setEncodingMock },
       on: vi.fn().mockImplementation((event: string, cb: (arg0: number) => void) => {
-        if (event === 'exit') {
+        if (event === 'close') {
           cb(0);
         }
       }),
@@ -320,7 +320,7 @@ describe('exec', () => {
       stdout: { on, setEncoding: setEncodingMock },
       stderr: { on, setEncoding: setEncodingMock },
       on: vi.fn().mockImplementation((event: string, cb: (arg0: number) => void) => {
-        if (event === 'exit') {
+        if (event === 'close') {
           cb(0);
         }
       }),
@@ -357,7 +357,7 @@ describe('exec', () => {
       stdout: { on, setEncoding: vi.fn() },
       stderr: { on, setEncoding: vi.fn() },
       on: vi.fn().mockImplementation((event: string, cb: (arg0: number) => void) => {
-        if (event === 'exit') {
+        if (event === 'close') {
           cb(0);
         }
       }),
@@ -393,7 +393,7 @@ describe('exec', () => {
       stdout: { on, setEncoding: vi.fn() },
       stderr: { on, setEncoding: vi.fn() },
       on: vi.fn().mockImplementation((event: string, cb: (arg0: number) => void) => {
-        if (event === 'exit') {
+        if (event === 'close') {
           cb(0);
         }
       }),
@@ -426,7 +426,7 @@ describe('exec', () => {
       stdout: { on, setEncoding: vi.fn() },
       stderr: { on, setEncoding: vi.fn() },
       on: vi.fn().mockImplementation((event: string, cb: (arg0: number) => void) => {
-        if (event === 'exit') {
+        if (event === 'close') {
           cb(0);
         }
       }),
@@ -463,7 +463,7 @@ describe('exec', () => {
       stdout: { on, setEncoding: vi.fn() },
       stderr: { on, setEncoding: vi.fn() },
       on: vi.fn().mockImplementation((event: string, cb: (arg0: number) => void) => {
-        if (event === 'exit') {
+        if (event === 'close') {
           cb(0);
         }
       }),
@@ -496,7 +496,7 @@ describe('exec', () => {
       stdout: { on, setEncoding: vi.fn() },
       stderr: { on, setEncoding: vi.fn() },
       on: vi.fn().mockImplementation((event: string, cb: (arg0: number) => void) => {
-        if (event === 'exit') {
+        if (event === 'close') {
           cb(0);
         }
       }),
@@ -527,7 +527,7 @@ describe('exec', () => {
       stdout: { on, setEncoding: setEncodingMock },
       stderr: { on, setEncoding: setEncodingMock },
       on: vi.fn().mockImplementation((event: string, cb: (arg0: number) => void) => {
-        if (event === 'exit') {
+        if (event === 'close') {
           cb(0);
         }
       }),

diff --git a/packages/main/src/plugin/util/exec.ts b/packages/main/src/plugin/util/exec.ts
@@ -210,7 +210,7 @@ export class Exec {
         reject(errResult);
       });
 
-      childProcess.on('exit', exitCode => {
+      childProcess.on('close', exitCode => {
         if (exitCode === 0) {
           const result: RunResult = {
             command,