chore: introduce a new property to switch to the new task manager panel

related to podman-desktop#9924 Signed-off-by: Florent Benoit <[email protected]>
SoniaSandler · Dec 3, 2024 · a5c4419 · a5c4419
1 parent d008854
commit a5c4419
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 3 deletions.
diff --git a/packages/api/src/tasks-preferences.ts b/packages/api/src/tasks-preferences.ts
@@ -20,4 +20,5 @@ export enum ExperimentalTasksSettings {
   SectionName = 'tasks',
   StatusBar = 'StatusBar',
   Toast = 'Toast',
+  Manager = 'Manager',
 }
diff --git a/packages/main/src/plugin/tasks/task-manager.spec.ts b/packages/main/src/plugin/tasks/task-manager.spec.ts
@@ -72,6 +72,20 @@ test('task manager init should register a configuration option', async () => {
       }),
     ]),
   );
+
+  expect(configurationRegistry.registerConfigurations).toHaveBeenCalledWith(
+    expect.arrayContaining([
+      expect.objectContaining({
+        properties: expect.objectContaining({
+          'tasks.Manager': {
+            type: 'boolean',
+            description: 'Replace the current task manager widget by the new one',
+            default: false,
+          },
+        }),
+      }),
+    ]),
+  );
 });
 
 test('create task with title', async () => {

diff --git a/packages/main/src/plugin/tasks/task-manager.ts b/packages/main/src/plugin/tasks/task-manager.ts
@@ -47,7 +47,14 @@ export class TaskManager {
     this.setStatusBarEntry(false);
 
     this.commandRegistry.registerCommand('show-task-manager', () => {
-      this.apiSender.send('toggle-task-manager', '');
+      // get the current value of the configuration flag for the task manager
+      const useExperimentalTaskManager = this.configurationRegistry
+        .getConfiguration(ExperimentalTasksSettings.SectionName)
+        .get<boolean>(ExperimentalTasksSettings.Manager, false);
+
+      const showEventName = useExperimentalTaskManager ? 'toggle-task-manager' : 'toggle-legacy-task-manager';
+
+      this.apiSender.send(showEventName, '');
       this.setStatusBarEntry(false);
     });
 
@@ -67,6 +74,11 @@ export class TaskManager {
             type: 'boolean',
             default: false,
           },
+          [`${ExperimentalTasksSettings.SectionName}.${ExperimentalTasksSettings.Manager}`]: {
+            description: 'Replace the current task manager widget by the new one',
+            type: 'boolean',
+            default: false,
+          },
         },
       },
     ]);

diff --git a/packages/renderer/src/lib/task-manager/LegacyTaskManager.svelte b/packages/renderer/src/lib/task-manager/LegacyTaskManager.svelte
@@ -31,8 +31,8 @@ function handleEscape({ key }: any) {
   }
 }
 
-// listen to the event "toggle-task-manager" to toggle the task manager
-window.events?.receive('toggle-task-manager', () => {
+// listen to the event "toggle-legacy-task-manager" to toggle the task manager
+window.events?.receive('toggle-legacy-task-manager', () => {
   showTaskManager = !showTaskManager;
 });
 </script>