fix: update cancelId to fix failing windows update e2e test (podman-d…

…esktop#9248) * fix: update cancelId to fix failing windows update e2e test Signed-off-by: Sonia Sandler <[email protected]>
SoniaSandler · Oct 7, 2024 · c7b7bfe · c7b7bfe
1 parent 0824904
commit c7b7bfe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/main/src/plugin/updater.spec.ts b/packages/main/src/plugin/updater.spec.ts
@@ -418,7 +418,7 @@ describe('expect update command to depends on context', async () => {
     await mListener?.('startup');
 
     expect(messageBoxMock.showMessageBox).toHaveBeenCalledWith({
-      cancelId: 1,
+      cancelId: 2,
       buttons: ['Update now', 'View release notes', 'Remind me later', 'Do not show again'],
       message:
         'A new version v@debug-next of Podman Desktop is available. Do you want to update your current version v@debug?',
@@ -434,7 +434,7 @@ describe('expect update command to depends on context', async () => {
     await mListener?.('status-bar-entry');
 
     expect(messageBoxMock.showMessageBox).toHaveBeenCalledWith({
-      cancelId: 1,
+      cancelId: 2,
       buttons: ['Update now', 'View release notes', 'Cancel'],
       message:
         'A new version v@debug-next of Podman Desktop is available. Do you want to update your current version v@debug?',
@@ -685,6 +685,7 @@ test('get release notes in dev mode', async () => {
       statusBarRegistryMock,
       commandRegistryMock,
       taskManagerMock,
+      apiSenderMock,
     );
 
     vi.spyOn(global, 'fetch').mockResolvedValueOnce({

diff --git a/packages/main/src/plugin/updater.ts b/packages/main/src/plugin/updater.ts
@@ -224,7 +224,7 @@ export class Updater {
         title: 'Update Available now',
         message: `A new version ${updateVersion} of Podman Desktop is available. Do you want to update your current version ${this.#currentVersion}?`,
         buttons: buttons,
-        cancelId: 1,
+        cancelId: 2,
       });
       if (result.response === 3) {
         this.updateConfigurationValue('never');