Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for 128 bit bitwise operation #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support for 128 bit bitwise operation #10

wants to merge 1 commit into from

Conversation

Sosutha
Copy link
Owner

@Sosutha Sosutha commented Sep 17, 2024

  • Added movh statement definition

@Sosutha Sosutha force-pushed the dpdk_128_bit_support branch 2 times, most recently from 10a1aac to 6a4c870 Compare September 24, 2024 11:35
@Sosutha Sosutha force-pushed the dpdk_128_bit_support branch 8 times, most recently from f41d23d to 06eb13a Compare October 1, 2024 11:06
@Sosutha Sosutha force-pushed the dpdk_128_bit_support branch 14 times, most recently from 9e9f473 to a0e34e4 Compare October 9, 2024 04:44
syogender
syogender reviewed Oct 9, 2024
View reviewed changes
backends/dpdk/dpdkHelpers.cpp Outdated
fields->push_back(new IR::StructField("upper_half", IR::Type_Bits::get(64)));
fields->push_back(new IR::StructField("lower_half", IR::Type_Bits::get(64)));
const IR::Type_Header *headerStruct = new IR::Type_Header(IR::ID("sandbox_header_t"), *fields);
auto name = new cstring("sandbox_header_t");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use some name which are not valid identifier in P4 say starting with $
x=same tmp128_t

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sandbox_header$_t

tmp128$_t

Are these fine?

syogender
syogender reviewed Oct 9, 2024
View reviewed changes
Copy link

@syogender syogender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a look at comment

@Sosutha Sosutha force-pushed the dpdk_128_bit_support branch 4 times, most recently from 30b7c86 to 21dd2e5 Compare October 10, 2024 12:13
@Sosutha Sosutha force-pushed the dpdk_128_bit_support branch 6 times, most recently from 0b866d7 to ae74cb8 Compare October 11, 2024 10:02
@Sosutha Sosutha force-pushed the dpdk_128_bit_support branch 9 times, most recently from 45bbda9 to d40ff2f Compare October 23, 2024 12:29
@Sosutha
Support for 128 bit operations
ce5265d 
Signed-off-by: Sosutha Sethuramapandian
<[email protected]>

* Added movh statement definition
* Added support for 128 bitwise operation
* Added support for 128 bit equal and not equal operators.
* Added support for 128 bit compliment operation
* Updated testcase and output
@Sosutha Sosutha force-pushed the dpdk_128_bit_support branch from d40ff2f to ce5265d Compare October 23, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syogender syogender syogender left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sosutha @syogender